Add test for accepting template defaults

code-asher · code-asher · commit 91d2269d07e1 · 2025-12-04T22:11:57.000-09:00
This works already in production, but not in the tests because the
generated Terraform was missing quotes around the default value, which
must have been breaking the parser because it was returning no
parameters.  Then we were removing all non-matching parameters from the
request, which was all of them since the parser returned none.
diff --git a/cli/create_test.go b/cli/create_test.go
@@ -384,6 +384,8 @@ func TestCreateWithRichParameters(t *testing.T) {
 		inputParameters []param
 		// expectedParameters defaults to inputParameters.
 		expectedParameters []param
+		// withDefaults sets DefaultValue to each parameter's value.
+		withDefaults bool
 	}{
 		{
 			name: "ValuesFromPrompt",
@@ -528,6 +530,21 @@ func TestCreateWithRichParameters(t *testing.T) {
 				return "other-workspace"
 			},
 		},
+		{
+			name: "ValuesFromTemplateDefaults",
+			handlePty: func(pty *ptytest.PTY) {
+				// Simply accept the defaults.
+				for _, param := range params {
+					pty.ExpectMatch(param.name)
+					pty.ExpectMatch(`Enter a value (default: "` + param.value + `")`)
+					pty.WriteLine("")
+				}
+				// Confirm the creation.
+				pty.ExpectMatch("Confirm create?")
+				pty.WriteLine("yes")
+			},
+			withDefaults: true,
+		},
 	}
 
 	for _, tt := range tests {
@@ -542,11 +559,16 @@ func TestCreateWithRichParameters(t *testing.T) {
 			// Convert parameters for the echo provisioner response.
 			var rparams []*proto.RichParameter
 			for i, param := range parameters {
+				defaultValue := ""
+				if tt.withDefaults {
+					defaultValue = param.value
+				}
 				rparams = append(rparams, &proto.RichParameter{
-					Name:    param.name,
-					Type:    param.ptype,
-					Mutable: param.mutable,
-					Order:   int32(i), //nolint:gosec
+					Name:         param.name,
+					Type:         param.ptype,
+					Mutable:      param.mutable,
+					DefaultValue: defaultValue,
+					Order:        int32(i), //nolint:gosec
 				})
 			}
 
diff --git a/provisioner/echo/serve.go b/provisioner/echo/serve.go
@@ -465,7 +465,15 @@ data "coder_parameter" "{{ .Name }}" {
   ephemeral    = {{ .Ephemeral }}
   order 	 = {{ .Order }}
 {{- if .DefaultValue }}
+  {{- if eq .Type "list(string)" }}
+  default      = jsonencode({{ .DefaultValue }})
+  {{else if eq .Type "bool"}}
   default      = {{ .DefaultValue }}
+  {{else if eq .Type "number"}}
+  default      = {{ .DefaultValue }}
+  {{else}}
+  default      = "{{ .DefaultValue }}"
+  {{- end }}
 {{- end }}
 {{- if .Type }}
   type      = "{{ .Type }}"
