refactor: move valid color overrides to tallymansdk package

deansheather · deansheather · commit 581064c3fbe0 · 2025-12-11T16:36:02.000Z
- Create tallymansdk.TallymanValidColorOverrides global variable
- Add documentation about Metronome color palette
- Update API to use tallymansdk.TallymanValidColorOverrides
- Remove local validColors map from licenses.go
diff --git a/enterprise/coderd/licenses.go b/enterprise/coderd/licenses.go
@@ -418,31 +418,8 @@ func (api *API) postUsageEmbeddableDashboard(rw http.ResponseWriter, r *http.Req
 	}
 
 	// Validate color override names. These must match the colors available in Metronome.
-	validColors := map[string]struct{}{
-		"Gray_dark":               {},
-		"Gray_medium":             {},
-		"Gray_light":              {},
-		"Gray_extralight":         {},
-		"White":                   {},
-		"Primary_medium":          {},
-		"Primary_light":           {},
-		"UsageLine_0":             {},
-		"UsageLine_1":             {},
-		"UsageLine_2":             {},
-		"UsageLine_3":             {},
-		"UsageLine_4":             {},
-		"UsageLine_5":             {},
-		"UsageLine_6":             {},
-		"UsageLine_7":             {},
-		"UsageLine_8":             {},
-		"UsageLine_9":             {},
-		"Primary_green":           {},
-		"Primary_red":             {},
-		"Progress_bar":            {},
-		"Progress_bar_background": {},
-	}
 	for _, override := range req.ColorOverrides {
-		if _, ok := validColors[override.Name]; !ok {
+		if _, ok := tallymansdk.TallymanValidColorOverrides[override.Name]; !ok {
 			httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
 				Message: "Invalid color name.",
 				Detail:  fmt.Sprintf("Color name %q is not a valid Metronome color", override.Name),
diff --git a/enterprise/coderd/usage/tallymansdk/dashboards.go b/enterprise/coderd/usage/tallymansdk/dashboards.go
@@ -8,6 +8,33 @@ import (
 	"golang.org/x/xerrors"
 )
 
+// TallymanValidColorOverrides contains the valid color names that can be overridden
+// in Metronome dashboards. These correspond to the color palette available in the
+// Metronome embedding API.
+var TallymanValidColorOverrides = map[string]struct{}{
+	"Gray_dark":               {},
+	"Gray_medium":             {},
+	"Gray_light":              {},
+	"Gray_extralight":         {},
+	"White":                   {},
+	"Primary_medium":          {},
+	"Primary_light":           {},
+	"UsageLine_0":             {},
+	"UsageLine_1":             {},
+	"UsageLine_2":             {},
+	"UsageLine_3":             {},
+	"UsageLine_4":             {},
+	"UsageLine_5":             {},
+	"UsageLine_6":             {},
+	"UsageLine_7":             {},
+	"UsageLine_8":             {},
+	"UsageLine_9":             {},
+	"Primary_green":           {},
+	"Primary_red":             {},
+	"Progress_bar":            {},
+	"Progress_bar_background": {},
+}
+
 // DashboardType represents the type of dashboard to embed.
 // Corresponds to codersdk.UsageEmbeddableDashboardType.
 type DashboardType string
