fix: close render cache even when reconciler never ran

Callum Styan · claude · Callum Styan · commit 4f9b23a11cfc · 2025-12-11T06:38:12.000Z
The reconciler's Stop() method was returning early if the reconciler was never started (running == false), which meant the render cache cleanup goroutine was never stopped. This happened in tests that create reconcilers but never call Run() on them. When Stop() was called in t.Cleanup(), it would skip closing the render cache, causing goroutine leaks. Fix: Move renderCache.Close() to execute before the running check, so the cleanup goroutine is always stopped regardless of whether the reconciler was ever started. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
diff --git a/enterprise/coderd/prebuilds/reconcile.go b/enterprise/coderd/prebuilds/reconcile.go
@@ -268,6 +268,10 @@ func (c *StoreReconciler) Stop(ctx context.Context, cause error) {
 		}
 	}
 
+	// Close the render cache to stop its cleanup goroutine
+	// This must be done regardless of whether the reconciler is running
+	c.renderCache.Close()
+
 	// If the reconciler is not running, there's nothing else to do.
 	if !c.running.Load() {
 		return
@@ -292,9 +296,6 @@ func (c *StoreReconciler) Stop(ctx context.Context, cause error) {
 	case <-c.done:
 		c.logger.Info(context.Background(), "reconciler stopped")
 	}
-
-	// Close the render cache to stop its cleanup goroutine
-	c.renderCache.Close()
 }
 
 // ReconcileAll will attempt to resolve the desired vs actual state of all templates which have presets with prebuilds configured.

Original file line number	Diff line number	Diff line change
`@@ -268,6 +268,10 @@ func (c *StoreReconciler) Stop(ctx context.Context, cause error) {`
`268`	`268`	`}`
`269`	`269`	`}`
`270`	`270`
	`271`	`+ // Close the render cache to stop its cleanup goroutine`
	`272`	`+ // This must be done regardless of whether the reconciler is running`
	`273`	`+ c.renderCache.Close()`
	`274`	`+`
`271`	`275`	`// If the reconciler is not running, there's nothing else to do.`
`272`	`276`	`if !c.running.Load() {`
`273`	`277`	`return`
`@@ -292,9 +296,6 @@ func (c *StoreReconciler) Stop(ctx context.Context, cause error) {`
`292`	`296`	`case <-c.done:`
`293`	`297`	`c.logger.Info(context.Background(), "reconciler stopped")`
`294`	`298`	`}`
`295`		`-`
`296`		`- // Close the render cache to stop its cleanup goroutine`
`297`		`- c.renderCache.Close()`
`298`	`299`	`}`
`299`	`300`
`300`	`301`	`// ReconcileAll will attempt to resolve the desired vs actual state of all templates which have presets with prebuilds configured.`