Use 404 instead of 403 for disabled endpoint

code-asher · code-asher · commit 353504834bca · 2025-12-10T18:34:04.000-09:00
diff --git a/coderd/coderd.go b/coderd/coderd.go
@@ -1534,8 +1534,8 @@ func New(options *Options) *API {
 					func(next http.Handler) http.Handler {
 						return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
 							if !options.DeploymentValues.TemplateInsights.Enable.Value() {
-								httpapi.Write(context.Background(), rw, http.StatusForbidden, codersdk.Response{
-									Message: "Forbidden.",
+								httpapi.Write(context.Background(), rw, http.StatusNotFound, codersdk.Response{
+									Message: "Not Found.",
 									Detail:  "Template insights are disabled.",
 								})
 								return
diff --git a/coderd/insights_test.go b/coderd/insights_test.go
@@ -2418,8 +2418,8 @@ func TestGenericInsights_Disabled(t *testing.T) {
 	tests := []struct {
 		name string
 		fn   func(ctx context.Context) error
-		// ok means there should be no error, otherwise assume forbidden due to
-		// being disabled.
+		// ok means there should be no error, otherwise assume 404 due to being
+		// disabled.
 		ok bool
 	}{
 		{
@@ -2478,7 +2478,7 @@ func TestGenericInsights_Disabled(t *testing.T) {
 				require.Error(t, err)
 				cerr := coderdtest.SDKError(t, err)
 				require.Contains(t, cerr.Error(), "disabled")
-				require.Equal(t, http.StatusForbidden, cerr.StatusCode())
+				require.Equal(t, http.StatusNotFound, cerr.StatusCode())
 			}
 		})
 	}
diff --git a/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.stories.tsx b/site/src/pages/TemplatePage/TemplateInsightsPage/TemplateInsightsPage.stories.tsx
@@ -29,24 +29,24 @@ export const Loading: Story = {
 	},
 };
 
-const forbidden = mockApiError({
-	message: "Forbidden.",
+const notFound = mockApiError({
+	message: "Not Found.",
 	detail: "Template insights are disabled.",
 });
 
 export const LoadingError: Story = {
 	args: {
 		templateInsights: {
 			data: undefined,
-			error: forbidden,
+			error: notFound,
 		},
 		userLatency: {
 			data: undefined,
-			error: forbidden,
+			error: notFound,
 		},
 		userActivity: {
 			data: undefined,
-			error: forbidden,
+			error: notFound,
 		},
 	},
 };

Original file line number	Diff line number	Diff line change
`@@ -2418,8 +2418,8 @@ func TestGenericInsights_Disabled(t *testing.T) {`
`2418`	`2418`	`tests := []struct {`
`2419`	`2419`	`name string`
`2420`	`2420`	`fn func(ctx context.Context) error`
`2421`		`- // ok means there should be no error, otherwise assume forbidden due to`
`2422`		`- // being disabled.`
	`2421`	`+ // ok means there should be no error, otherwise assume 404 due to being`
	`2422`	`+ // disabled.`
`2423`	`2423`	`ok bool`
`2424`	`2424`	`}{`
`2425`	`2425`	`{`
`@@ -2478,7 +2478,7 @@ func TestGenericInsights_Disabled(t *testing.T) {`
`2478`	`2478`	`require.Error(t, err)`
`2479`	`2479`	`cerr := coderdtest.SDKError(t, err)`
`2480`	`2480`	`require.Contains(t, cerr.Error(), "disabled")`
`2481`		`- require.Equal(t, http.StatusForbidden, cerr.StatusCode())`
	`2481`	`+ require.Equal(t, http.StatusNotFound, cerr.StatusCode())`
`2482`	`2482`	`}`
`2483`	`2483`	`})`
`2484`	`2484`	`}`