packages/runtime-core/src/components/BaseTransition.ts (1)

203-210: Correct arg order for isSameVNodeType (old, new) — fixes HMR with KeepAlive+Transition

Swapping to isSameVNodeType(oldInnerChild, innerChild) aligns with the function’s HMR guard which expects (oldVNode, newVNode). This prevents stale instances from being “kept alive” across HMR. Looks good.

Consider an inline comment to prevent future regressions:

-      if (
+      // HMR note: pass (old, new) to isSameVNodeType
+      if (
         oldInnerChild &&
         oldInnerChild.type !== Comment &&
         !isSameVNodeType(oldInnerChild, innerChild) &&
         recursiveGetSubtree(instance).type !== Comment
       ) {

packages/runtime-core/src/components/Suspense.ts (1)

236-244: All three comparisons now pass (old, new) into isSameVNodeType — matches HMR contract

• pending vs new branch
• active vs new branch (both pending and non-pending paths)

These swaps ensure the HMR dirty-instance check runs and the keep-alive flags are adjusted on the correct sides. Nice.

Add a short comment once to document the non-commutative intent:

-    if (isSameVNodeType(pendingBranch, newBranch)) {
+    // HMR note: isSameVNodeType expects (old, new)
+    if (isSameVNodeType(pendingBranch, newBranch)) {

Also applies to: 324-339, 358-372

packages/runtime-core/__tests__/hmr.spec.ts (1)

898-949: Good regression coverage for multi-reload with KeepAlive outside Suspense

The test reproduces the “second reload doesn’t update” edge case and validates both successive updates. LGTM.

For tighter determinism (no macro-task dependency), consider await nextTick() after each reload (this test is fully sync aside from HMR scheduling):

-    await timeout()
+    await nextTick()
...
-    await timeout()
+    await nextTick()

Optionally DRY the reload steps:

+    const reloadTo = (n: number) =>
+      reload(id, {
+        __hmrId: id,
+        setup() { return { count: ref(n) } },
+        render: compileToFunction(`<div>{{ count }}</div>`),
+      })
...
-    reload(id, { ...count: ref(1)... }); await nextTick()
+    reloadTo(1); await nextTick()
...
-    reload(id, { ...count: ref(2)... }); await nextTick()
+    reloadTo(2); await nextTick()

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.