🐛 Fix nested dataclass comparison #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how
IsDataclasshandles nested dataclasses so they can be compared successfully. Previously something like the following would not work:This is a result of
IsDataclassconverting dataclasses to a dictionary for comparison usingdataclasses.asdict, which recursively converts dataclasses to plain dictionaries. Thus the innerIsDataclassfails, because the other side of the comparison is now a dictionary, not a dataclass.These changes fix this by shallowly converting the dataclass to a dictionary using the approach recommended in the dataclasses documentation:
{field.name: getattr(obj, field.name) for field in fields(obj)}These changes also include a test for nested dataclass comparisons to ensure this works as expected and continues to work in the future.