Skip to content

fix(typing): put EllipsisType in LengthType union #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
15r10nk merged 6 commits into from
Sep 17, 2025
Merged

fix(typing): put EllipsisType in LengthType union #116

15r10nk merged 6 commits into from
Sep 17, 2025

Conversation

@lucascolley
Copy link
Contributor

@lucascolley lucascolley commented Jul 31, 2025 •
edited
Loading 

tests/integration_python/test_main_cli.py:1481: error: No overload variant of "IsList" matches argument type "EllipsisType"  [call-overload]
tests/integration_python/test_main_cli.py:1481: note: Possible overload variants:
tests/integration_python/test_main_cli.py:1481: note:     def IsList(self, *items: Any, check_order: bool = ..., length: int | tuple[int, int | Any] | None = ...) -> IsList
tests/integration_python/test_main_cli.py:1481: note:     def IsList(self, positions: dict[int, Any], length: int | tuple[int, int | Any] | None = ...) -> IsList

An ellipsis is a valid argument, as shown in the docs: https://dirty-equals.helpmanual.io/latest/types/sequence/?h=isl#dirty_equals.IsList.

closes gh-110

@lucascolley lucascolley mentioned this pull request Aug 24, 2025
Closed
@lucascolley
Copy link
Contributor Author

lucascolley commented Aug 24, 2025

gentle ping @samuelcolvin :)

@lucascolley
Copy link
Contributor Author

lucascolley commented Sep 16, 2025

@FBruzzesi maybe you could take a look?

FBruzzesi
FBruzzesi reviewed Sep 16, 2025
View reviewed changes
Copy link
Contributor

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucascolley thanks for the ping, that left me with a big smile and some confusion - for context I am not related with this project, just a big fan and user of it

I left a couple of comments, one much more relevant than the other

dirty_equals/_sequence.py
if sys.version_info >= (3, 10):
from types import EllipsisType
else:
EllipsisType = Any
Copy link
Contributor

@FBruzzesi FBruzzesi Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't try this, but maybe some hack like the following could work as a "backport"

Suggested change
EllipsisType = Any
from typing import Type
EllipsisType = Type[class(Ellipsis)]

but also, py3.9 will reach end of life in a month anyway

@lucascolley
Copy link
Contributor Author

lucascolley commented Sep 16, 2025

for context I am not related with this project, just a big fan and user of it

I figured :) unfortunately the (sole?) maintainer is unresponsive

@lucascolley @FBruzzesi
Update _sequence.py
bbe181c 
Co-authored-by: Francesco Bruzzesi <42817048+FBruzzesi@users.noreply.github.com>
@15r10nk
Copy link
Collaborator

15r10nk commented Sep 17, 2025

No, he's not the only one. I can merge it if you want, but I don't know how releases are handled in this project.

@lucascolley
Copy link
Contributor Author

lucascolley commented Sep 17, 2025

Sounds good @15r10nk, thanks!

Maybe you have some other channel of communication with him?

@samuelcolvin
Copy link
Owner

samuelcolvin commented Sep 17, 2025

Sorry for the slow reply, I'll look today

@15r10nk 15r10nk merged commit cb52dd2 into samuelcolvin:main Sep 17, 2025
20 checks passed
@lucascolley lucascolley deleted the patch-1 branch September 17, 2025 18:36
@lucascolley
Copy link
Contributor Author

lucascolley commented Sep 17, 2025

no rush for a new release, but one at some point would be fantastic, thanks!

For context, we have started using inline-snapshot and dirty-equals in https://github.com/prefix-dev/pixi. Thanks for the tools!

@samuelcolvin
Copy link
Owner

samuelcolvin commented Sep 19, 2025

thanks all for your work on this, I'll try to do a release tomorrow. If I forget, please ping me on email or twitter.

@samuelcolvin
Copy link
Owner

samuelcolvin commented Sep 19, 2025

Release done. Sorry again for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@FBruzzesi FBruzzesi FBruzzesi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucascolley @15r10nk @samuelcolvin @FBruzzesi