Skip to content

feat: show owner module id for "canonical name not found for" errors #5288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sapphi-red
Copy link
Collaborator

@sapphi-red sapphi-red commented Jul 15, 2025

Improved the error message for "canonical name not found for" errors so that it's easier to find out the cause.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6e092b1
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68765b22d8d0200008017c89

@sapphi-red sapphi-red marked this pull request as ready for review July 15, 2025 13:46
@hyf0 hyf0 added this pull request to the merge queue Jul 15, 2025
Copy link
Contributor

Benchmarks Rust

  • target: main(cd4c452)
  • pr: 07-15-feat_show_owner_module_id_for_canonical_name_not_found_for_errors(6e092b1)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     91.9±5.12ms        ? ?/sec    1.00     89.0±3.10ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.05    105.9±3.88ms        ? ?/sec    1.00    100.9±3.58ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    127.7±4.72ms        ? ?/sec    1.00    125.3±2.27ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    149.4±3.37ms        ? ?/sec    1.00    147.7±2.51ms        ? ?/sec
bundle/bundle@threejs                                        1.00     46.7±1.15ms        ? ?/sec    1.00     46.7±2.27ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     57.5±1.16ms        ? ?/sec    1.00     56.1±0.95ms        ? ?/sec
bundle/bundle@threejs10x                                     1.03    490.0±7.37ms        ? ?/sec    1.00   473.6±10.06ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.03   582.2±10.40ms        ? ?/sec    1.00    563.7±8.13ms        ? ?/sec
scan/scan@rome_ts                                            1.00     97.4±2.34ms        ? ?/sec    1.00     97.7±2.47ms        ? ?/sec
scan/scan@threejs                                            1.03     35.0±1.89ms        ? ?/sec    1.00     34.0±2.13ms        ? ?/sec
scan/scan@threejs10x                                         1.01    346.4±6.46ms        ? ?/sec    1.00    342.3±6.04ms        ? ?/sec

Merged via the queue into main with commit 97831d7 Jul 15, 2025
25 checks passed
@hyf0 hyf0 deleted the 07-15-feat_show_owner_module_id_for_canonical_name_not_found_for_errors branch July 15, 2025 14:01
This was referenced Jul 17, 2025
shulaoda pushed a commit that referenced this pull request Jul 17, 2025
## [1.0.0-beta.28] - 2025-07-17

### 🚀 Features

- rolldown: oxc v0.77.2 (#5328) by @Boshen
- hmr: add `module` and `exports` parameters to CJS initializer
functions (#5322) by @hyf0
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#318`
(#5318) by @shulaoda
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#315`
(#5315) by @shulaoda
- hmr: automatically disable treeshaking in hmr (#5311) by @hyf0
- hmr: use `trait HmrAstBuilder` to unify ast construction (#5310) by
@hyf0
- rolldown_plugin_chunk_import_map: basic implementation (#5307) by
@shulaoda
- add `watch.onInvalidate` (#5239) by @situ2001
- rolldown_plugin_chunk_import_map: implement initial `render_chunk`
logic (#5306) by @shulaoda
- rolldown: oxc v0.77.1 (#5304) by @Boshen
- js: expose `experimental.incrementalBuild` option (#5300) by
@IWANABETHATGUY
- js: support `experimental.onDemandWrapping` option (#5299) by
@IWANABETHATGUY
- support on demand wrapping for entry chunk (#5291) by @IWANABETHATGUY
- rolldown_plugin_chunk_import_map: initialize (#5289) by @shulaoda
- show owner module id for "canonical name not found for" errors (#5288)
by @sapphi-red

### 🐛 Bug Fixes

- only transform VarDeclaration when enable `keepNames` (#5323) by
@IWANABETHATGUY
- keepNames with special Ifstmt (#5320) by @IWANABETHATGUY
- incremental watch panic when adding dynamic import (#5309) by
@IWANABETHATGUY
- make leaf module wrapping optimization opt-in (#5305) by
@IWANABETHATGUY
- `keepNames` should consider exportNamed function declaration (#5298)
by @IWANABETHATGUY
- undefined `process.versions` for browser build (#5295) by @sxzz
- sanitizeFileName: entry name should be sanitized (#5283) by @shulaoda
- minify-internal-exports: ensure minifying internal exports stably
(#5281) by @hyf0
- keep legal and annotation comments for `minify: 'dce-only'` (#5280) by
@sapphi-red
- unstable chunk generation when `preserveEntrySignatures: false` is
used (#5274) by @IWANABETHATGUY

### 🚜 Refactor

- pass the while CodegenOptions to `EcmaCompiler::minify` (#5279) by
@sapphi-red
- avoid iterate `canonical_exports` twice (#5276) by @IWANABETHATGUY

### 📚 Documentation

- pluginutils: add README file (#5262) by @TheAlexLichter

### ⚡ Performance

- inline function expression when rewriting `name` property with
`keepNames` enabled (#5321) by @IWANABETHATGUY
- rolldown_sourcemap: cache source id -> source text mapping (#5285) by
@Boshen
- rolldown_sourcemap: disable rayon (#5284) by @Boshen

### 🧪 Testing

- rust: prevent meaningless snapshot change from bumping oxc runtime
versions (#5312) by @hyf0

### ⚙️ Miscellaneous Tasks

- upgrade to NAPI-RS 3.0 stable (#5324) by @Brooooooklyn
- infra: add onlyBuiltDependencies (#5287) by @situ2001
- improve the order of import keys in the exports field (#5314) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.14 (#5293) by
@renovate[bot]
- deps: lock file maintenance rust crates (#5267) by @renovate[bot]
- deps: lock file maintenance npm packages (#5266) by @renovate[bot]
- deps: update github-actions (#5265) by @renovate[bot]

### ❤️ New Contributors

* @situ2001 made their first contribution in
[#5287](#5287)

Co-authored-by: IWANABETHATGUY <17974631+IWANABETHATGUY@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants