Skip to content

Conversation

@Its-Just-Nans
Copy link
Contributor

May fix #981

@codecov
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.41%. Comparing base (41a0ca8) to head (25cedc8).

Files with missing lines Patch % Lines
pdfarranger/pdfarranger.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
- Coverage   78.47%   78.41%   -0.06%     
==========================================
  Files          13       13              
  Lines        5166     5175       +9     
==========================================
+ Hits         4054     4058       +4     
- Misses       1112     1117       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbengs
Copy link
Member

kbengs commented Nov 17, 2024

This is a quite special use case.. Are there other applications which has this kind of flag? I am wondering how many users would find this useful?

@dreua
Copy link
Member

dreua commented Jun 28, 2025

Sorry for the late reply here, I labeled the issue feature without further comment because I thought it could be useful for some people who prefer the command line wherever possible, but fall back to PDF Arranger for picking out or modifying some pages (which is rather hard on a text only command line ui wise). There were at least three users interested in this, one creating the issue, one upvoting and @Its-Just-Nans creating this PR. Although none of them answered your question here unfortunately, which makes me wonder if we should just close it until there is further interest.

In case this should be pursued further: It should be --files-out imo, the minus is more common and easier to type. (Unless there are reasons against that.)

The code is not too many lines but it kinda is all over the place, so good testing, maybe even automatic tests should be conducted to make sure it does not have unintended side-effects.

@dreua
Copy link
Member

dreua commented Jun 28, 2025

... the issue asked for a flag to set the output file name if I'm not mistaken, this PR is about the output directory. This also shows that files-out is not a great name because it is ambiguous on whether it is about files or a directory.

@dreua
Copy link
Member

dreua commented Jun 28, 2025

And in general I'd recommend to discuss a feature before coding it. The complexity here is often not in the code but in the interfaces and usability. That needs communication rather than PRs first.

@kbengs
Copy link
Member

kbengs commented Jun 29, 2025

If there are three users interested I am not against merging it. Currently there are conflicts that need to be resolved also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--files_out command line argument

3 participants