-
Notifications
You must be signed in to change notification settings - Fork 271
add directory flag #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add directory flag #1147
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 78.47% 78.41% -0.06%
==========================================
Files 13 13
Lines 5166 5175 +9
==========================================
+ Hits 4054 4058 +4
- Misses 1112 1117 +5 ☔ View full report in Codecov by Sentry. |
|
This is a quite special use case.. Are there other applications which has this kind of flag? I am wondering how many users would find this useful? |
|
Sorry for the late reply here, I labeled the issue In case this should be pursued further: It should be The code is not too many lines but it kinda is all over the place, so good testing, maybe even automatic tests should be conducted to make sure it does not have unintended side-effects. |
|
... the issue asked for a flag to set the output file name if I'm not mistaken, this PR is about the output directory. This also shows that |
|
And in general I'd recommend to discuss a feature before coding it. The complexity here is often not in the code but in the interfaces and usability. That needs communication rather than PRs first. |
|
If there are three users interested I am not against merging it. Currently there are conflicts that need to be resolved also. |
May fix #981