Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What did you do? Please include the actual source code causing the issue.

import type { AST, Rule } from 'eslint';

function getAllComments(node: Rule.Node): AST.Token[] {
    while (node.parent) {
        node = node.parent;
    }
    return node.comments;
}

Repro

What did you expect to happen?

The above TypeScript code should compile.

What actually happened? Please include the actual, raw output from ESLint.

A compiler error:

error TS2339: Property 'comments' does not exist on type 'Node'.
  Property 'comments' does not exist on type 'AssignmentProperty & NodeParentExtension'.

7   return node.comments;
                ~~~~~~~~

What changes did you make? (Give an overview)

This PR changes the type of the Program node in the Rule.Node union from ESTree.Program to AST.Program & { parent: null; }. This add the properties comments and tokens that were previously missing and changes the type of the parent property from Rule.Node to null.

I also updated and simplified Rule.NodeListener with the updated Rule.Node union using a mapped type. This change also fixes another unrelated bug in the type of the CallExpression visitor, exemplified in the code below:

import type { JSRuleDefinition } from 'eslint';

const rule: JSRuleDefinition = {
  create() {
    return {
      CallExpression(node) {
        node.type satisfies 'CallExpression';
      },
    };
  },
};

This currently fails with a compiler error:

error TS1360: Type '"CallExpression" | "NewExpression"' does not satisfy the expected type '"CallExpression"'.
  Type '"NewExpression"' is not assignable to type '"CallExpression"'.

7         node.type satisfies 'CallExpression';

The reason is that ESTree.CallExpression is confusingly defined as union of nodes where type can be one of CallExpression or NewExpression (reference):

export type CallExpression = SimpleCallExpression | NewExpression;

export interface SimpleCallExpression extends BaseCallExpression {
    type: "CallExpression";
    optional: boolean;
}

export interface NewExpression extends BaseCallExpression {
    type: "NewExpression";
}

Repro

The new definition avoids such bugs by ensuring that a visitor's key and node type are identical for all standard nodes.

Is there anything you'd like reviewers to focus on?