chore: cleanup

jaaydenh · jaaydenh · commit f40a70808ef9 · 2025-08-08T23:13:38.000Z
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.test.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.test.tsx
@@ -3,17 +3,17 @@ import userEvent from "@testing-library/user-event";
 import { API } from "api/api";
 import type { DynamicParametersResponse } from "api/typesGenerated";
 import {
+	MockDropdownParameter,
+	MockDynamicParametersResponse,
+	MockDynamicParametersResponseWithError,
 	MockPermissions,
+	MockSliderParameter,
 	MockTemplate,
 	MockTemplateVersionExternalAuthGithub,
 	MockTemplateVersionExternalAuthGithubAuthenticated,
 	MockUserOwner,
-	MockWorkspace,
-	MockDropdownParameter,
-	MockSliderParameter,
 	MockValidationParameter,
-	MockDynamicParametersResponse,
-	MockDynamicParametersResponseWithError,
+	MockWorkspace,
 } from "testHelpers/entities";
 import {
 	renderWithAuth,
@@ -57,7 +57,9 @@ describe("CreateWorkspacePageExperimental", () => {
 					callbacks.onMessage(JSON.parse(event.data));
 				});
 				mockWebSocket.addEventListener("error", () => {
-					callbacks.onError(new Error("Connection for dynamic parameters failed."));
+					callbacks.onError(
+						new Error("Connection for dynamic parameters failed."),
+					);
 				});
 				mockWebSocket.addEventListener("close", () => {
 					callbacks.onClose();
@@ -112,7 +114,9 @@ describe("CreateWorkspacePageExperimental", () => {
 						callbacks.onMessage(JSON.parse(event.data));
 					});
 					mockWebSocket.addEventListener("error", () => {
-						callbacks.onError(new Error("Connection for dynamic parameters failed."));
+						callbacks.onError(
+							new Error("Connection for dynamic parameters failed."),
+						);
 					});
 					mockWebSocket.addEventListener("close", () => {
 						callbacks.onClose();
@@ -167,13 +171,9 @@ describe("CreateWorkspacePageExperimental", () => {
 						callbacks.onError(new Error("Connection failed"));
 					});
 
-					setTimeout(() => {
-						publisher.publishError(
-							new ErrorEvent("error", {
-								error: new Error("Connection failed"),
-							}),
-						);
-					}, 10);
+					queueMicrotask(() =>
+						publisher.publishError(new Event("Connection failed")),
+					);
 
 					return mockWebSocket;
 				});
@@ -195,9 +195,7 @@ describe("CreateWorkspacePageExperimental", () => {
 						callbacks.onClose();
 					});
 
-					setTimeout(() => {
-						publisher.publishClose(new CloseEvent("close"));
-					}, 10);
+					queueMicrotask(() => publisher.publishClose(new CloseEvent("close")));
 
 					return mockWebSocket;
 				});
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -5,7 +5,6 @@ import {
 } from "api/api";
 import type { FieldError } from "api/errors";
 import type * as TypesGen from "api/typesGenerated";
-import { DynamicParametersResponse } from "api/typesGenerated";
 import type { ProxyLatencyReport } from "contexts/useProxyLatency";
 import range from "lodash/range";
 import type { Permissions } from "modules/permissions";
@@ -3274,32 +3273,34 @@ export const MockValidationParameter: TypesGen.PreviewParameter = {
 	order: 1,
 };
 
-export const MockDynamicParametersResponse: TypesGen.DynamicParametersResponse = {
-	id: 1,
-	parameters: [
-		MockDropdownParameter,
-		MockSliderParameter,
-		MockSwitchParameter,
-		MockTagSelectParameter,
-		MockMultiSelectParameter,
-	],
-	diagnostics: [],
-};
+export const MockDynamicParametersResponse: TypesGen.DynamicParametersResponse =
+	{
+		id: 1,
+		parameters: [
+			MockDropdownParameter,
+			MockSliderParameter,
+			MockSwitchParameter,
+			MockTagSelectParameter,
+			MockMultiSelectParameter,
+		],
+		diagnostics: [],
+	};
 
-export const MockDynamicParametersResponseWithError: TypesGen.DynamicParametersResponse = {
-	id: 2,
-	parameters: [MockDropdownParameter],
-	diagnostics: [
-		{
-			severity: "error",
-			summary: "Validation failed",
-			detail: "The selected instance type is not available in this region",
-			extra: {
-				code: "",
+export const MockDynamicParametersResponseWithError: TypesGen.DynamicParametersResponse =
+	{
+		id: 2,
+		parameters: [MockDropdownParameter],
+		diagnostics: [
+			{
+				severity: "error",
+				summary: "Validation failed",
+				detail: "The selected instance type is not available in this region",
+				extra: {
+					code: "",
+				},
 			},
-		},
-	],
-};
+		],
+	};
 
 export const MockTemplateVersionExternalAuthGithub: TypesGen.TemplateVersionExternalAuth =
 	{
