Skip to content

Conversation

@hieptl
Copy link
Collaborator

@hieptl hieptl commented Dec 8, 2025

Summary of PR

Steps to Reproduce:

  • Navigate to the LLM Basic Settings view. Select the OpenHands provider, choose a model, and click Save Settings.
  • Refresh the page, navigate to the LLM Advanced Settings view, and observe the UI.

Current Behavior:

  • The API key input field is visible.

Expected Behavior:

  • The API key input field should remain hidden when the current provider is OpenHands.

Change Type

  • Bug fix
  • New feature
  • Breaking change
  • Refactor
  • Other (dependency update, docs, typo fixes, etc.)

Checklist

  • I have read and reviewed the code and I understand what the code is doing.
  • I have tested the code to the best of my ability and ensured it works as expected.

Fixes

Resolves #(issue)

Release Notes

  • Include this change in the Release Notes.

To run this PR locally, use the following command:

GUI with Docker:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.openhands.dev/openhands/runtime:8f4ae00-nikolaik   --name openhands-app-8f4ae00   docker.openhands.dev/openhands/openhands:8f4ae00

@hieptl hieptl self-assigned this Dec 8, 2025
@hieptl hieptl requested a review from amanape as a code owner December 8, 2025 10:54
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Collaborator

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Can you update the tests please? For the future, let’s try to update or add features through TDD

@hieptl
Copy link
Collaborator Author

hieptl commented Dec 8, 2025

Thank you. Can you update the tests please? For the future, let’s try to update or add features through TDD

Hello @amanape,

I have updated the code based on your feedback.

When you have a moment, could you please help me review the pull request again?

Thank you for your feedback! 🙏

@openhands-ai
Copy link

openhands-ai bot commented Dec 8, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Run Python Tests
    • Run Frontend Unit Tests

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #11949 at branch `hieptl/app-228`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

Copy link
Collaborator

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@hieptl hieptl merged commit bf06b7e into main Dec 8, 2025
25 of 27 checks passed
@hieptl hieptl deleted the hieptl/app-228 branch December 8, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants