[#4009] fix(eventhandling): Invoke AbstractEventProcessor#reportIgnored through the SubscribingEventProcessor
#4011
Conversation
…red` through the `SubscribingEventProcessor`
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #4009 by implementing proper reporting of ignored events in SubscribingEventProcessor. Previously, events that could not be handled were silently skipped without notifying the configured MessageMonitor. Now, the processor filters events before creating a batch and explicitly calls reportIgnored() for unhandled events, ensuring proper monitoring and metrics collection.
Key changes:
- Implemented event filtering logic in
SubscribingEventProcessor.process()to check each event withcanHandle()before batching - Events that cannot be handled are now reported as ignored via
reportIgnored(), notifying the MessageMonitor - Added comprehensive test coverage to verify the ignored event reporting behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
messaging/src/main/java/org/axonframework/eventhandling/SubscribingEventProcessor.java |
Adds filtering logic to check if events can be handled before batching; reports unhandled events as ignored to MessageMonitor; updates documentation to reflect new behavior |
integrationtests/src/test/java/org/axonframework/integrationtests/eventhandling/SubscribingEventProcessorTest.java |
Adds default mock behavior for canHandle() in setUp; implements new test case verifying that reportIgnored() is called for events without handlers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nore String event - Added String event handler to SubscribingEventHandler in EventProcessingModuleTest to properly test span creation
|
closes #4009