Skip to content

Conversation

@abuijze
Copy link
Member

@abuijze abuijze commented Nov 26, 2025

No description provided.

@abuijze abuijze self-assigned this Nov 26, 2025
@abuijze abuijze requested a review from a team as a code owner November 26, 2025 09:56
@abuijze abuijze requested review from MateuszNaKodach, hatzlj and smcvb and removed request for a team November 26, 2025 09:56
@abuijze abuijze added Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Status: In Progress Use to signal this issue is actively worked on. Type: Documentation Use to signal issues that describe documentation work. labels Nov 26, 2025
@abuijze abuijze changed the base branch from main to doc/doc-migration November 26, 2025 09:56
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
67 Security Hotspots
56.5% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@smcvb smcvb added this to the Release 5.1.0 milestone Nov 26, 2025
@smcvb smcvb removed the Status: In Progress Use to signal this issue is actively worked on. label Nov 26, 2025
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions of changes I don't think apply to this PR. But, the brunt, being the rewrite of serialization.adoc to conversion.adoc, seems fine to me. Hence, I am approving this PR.

@@ -1 +1 @@
/Users/dgomezg/projects/axon/axoniq-library-ui No newline at end of file
/home/abuijze/workspaces/axoniq-library-ui No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although having it settled on @dgomezg was wrong, I don't think it should be settled on @abuijze either 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree 🤣

import com.fasterxml.jackson.databind.ObjectMapper;
import org.axonframework.conversion.json.JacksonConverter;

public class ScratchPad {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious: What's this ScratchPad for?

messages: jackson
----

== Message type resolution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering whether this section belongs strictly here. Sure, from a conversion perspective it is valuable, so having "something" on it here makes sense.

But, for AF3 and AF4, we had a messaging concepts section. I personally think this belongs there. Note something strictly to be done now, but something to think about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Type: Documentation Use to signal issues that describe documentation work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants