-
Notifications
You must be signed in to change notification settings - Fork 826
Doc/doc migration conversion #3954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: doc/doc-migration
Are you sure you want to change the base?
Conversation
|
smcvb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions of changes I don't think apply to this PR. But, the brunt, being the rewrite of serialization.adoc to conversion.adoc, seems fine to me. Hence, I am approving this PR.
| @@ -1 +1 @@ | |||
| /Users/dgomezg/projects/axon/axoniq-library-ui No newline at end of file | |||
| /home/abuijze/workspaces/axoniq-library-ui No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree 🤣
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import org.axonframework.conversion.json.JacksonConverter; | ||
|
|
||
| public class ScratchPad { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious: What's this ScratchPad for?
| messages: jackson | ||
| ---- | ||
|
|
||
| == Message type resolution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering whether this section belongs strictly here. Sure, from a conversion perspective it is valuable, so having "something" on it here makes sense.
But, for AF3 and AF4, we had a messaging concepts section. I personally think this belongs there. Note something strictly to be done now, but something to think about.




No description provided.