feat(Avatar): improve image loading status handling and add crossOrigin prop #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Member
|
Thanks @sadeghbarati !! Can you check the failing test? 😁 |
zernonia
reviewed
Apr 22, 2025
packages/core/src/Avatar/utils.ts
Outdated
| image.referrerPolicy = referrer | ||
| } | ||
| } | ||
| watch([() => src.value, () => referrerPolicy?.value, () => crossOrigin?.value], ([src, referrerPolicy], _, onCleanup) => { |
Member
There was a problem hiding this comment.
onCleanup in watch is 3.5+ feature, I believe this might not a feasible solution for earlier version. Perhaps use watchEffect?
Collaborator
Author
There was a problem hiding this comment.
Hi Zernonia 👋
Right, will change it
Collaborator
Author
|
Could you please update the tests 😄 |
Collaborator
Author
|
Don't understand why the test is failing cause the img element is present (console.log in Avatar utils.ts)
|
Member
|
No worry @sadeghbarati ! I can help with fixing the failed test. We might need to mock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from radix-ui