Skip to content

Conversation

@epr3
Copy link
Collaborator

@epr3 epr3 commented Apr 4, 2025

Added property that disables days outside current view.

@epr3 epr3 added the v2 label Apr 4, 2025
@epr3 epr3 requested a review from zernonia April 4, 2025 16:09
@epr3 epr3 self-assigned this Apr 4, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/reka-ui@1799

commit: eb691da

@zernonia
Copy link
Member

zernonia commented May 6, 2025

@epr3 do we want to disable the select action as well when this prop is enabled?

@epr3
Copy link
Collaborator Author

epr3 commented May 8, 2025

@zernonia Yes, we should do that. I'll update the PR in a bit.

@zernonia
Copy link
Member

@epr3 Can you resolve the conflicts? Also I'm running into issue with all the cell being disabled in the latest commit 🤔

@epr3
Copy link
Collaborator Author

epr3 commented May 19, 2025

@zernonia Sure thing! 👍

@zernonia zernonia merged commit 028785b into v2 May 24, 2025
6 of 7 checks passed
@Lakphy
Copy link
Contributor

Lakphy commented Jun 12, 2025

It seems that during conflict resolution, you accidentally removed my compatibility adjustments for applications using Vue below version 3.5 in useId.ts. Could you please confirm if your changes are necessary and right? Thank you very much!
028785b#r159807212

@epr3
Copy link
Collaborator Author

epr3 commented Jun 12, 2025

@Lakphy Hello, I am deeply sorry about overwriting your changes.

Probably either the linter or as you said a merge conflict resolution might have caused this.

I'll try to get up a hotfix PR as soon as I am able and reset the changes on useId.

Thank you very much for pointing this out. 🚀

@sadeghbarati sadeghbarati deleted the feat-disable-days-outside-month branch September 9, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants