feat(Popper): Add flip options props #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Contributor
Author
zernonia
approved these changes
Jul 15, 2025
Member
zernonia
left a comment
There was a problem hiding this comment.
Thanks for the PR @aguingand ! These 2 props seems useful to configure the flipping behavior! 💪🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some cases when you need to shift position according to boundary but not completely flipping to the other sides (e.g. popovers with contents only making sense underneath a field). I have added
sideFlip&alignFlipprops which correspond to mainAxis & crossAxis floating-uiflip()options. At first I was thinking of an unique property to disable flipping completely but two prop for each axis seems better for more fine-grained options.