Docs: use consistent HTML elements in Utilities > Background page #39519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

julien-deramond merged 2 commits into main from main-jd-consistent-utilities-background-html-elements

Dec 22, 2023

Member

julien-deramond commented Dec 21, 2023 •

edited

Loading

Description

This PR brings more consistency to our Utilities > Background page by using the same HTML element everywhere for the same rendering.

@patrickhlauke I've used <div>s because the entire page was already using mostly <div>s. However, I'm wondering, in terms of documentation accessibility, if it wouldn't be better to use <p>s instead everywhere. What do you think?

Motivation & Context

Consistency.

Type of changes

Docs refactoring (non-breaking change)

Checklist

I have read the contributing guidelines
My code follows the code style of the project (using npm run lint)
My change introduces changes to the documentation
I have updated the documentation accordingly
(N/A) I have added tests to cover my changes
All new and existing tests passed

Live previews

https://deploy-preview-39519--twbs-bootstrap.netlify.app/docs/5.3/utilities/background/


          Docs: use consistent HTML elements in Utilities > Background page

f8890fc

julien-deramond added docs v5 enhancement labels

julien-deramond marked this pull request as ready for review

December 21, 2023 14:16

julien-deramond requested a review from patrickhlauke

December 21, 2023 14:20

mdo approved these changes

View reviewed changes

Member

patrickhlauke commented Dec 21, 2023

However, I'm wondering, in terms of documentation accessibility, if it wouldn't be better to use <p>s instead everywhere. What do you think?

won't make any practical difference, so this is good to go


          Merge branch 'main' into main-jd-consistent-utilities-background-html…

15ef8d8

…-elements

patrickhlauke approved these changes

View reviewed changes

julien-deramond merged commit 00317d2 into main

julien-deramond deleted the main-jd-consistent-utilities-background-html-elements branch

December 22, 2023 06:14

romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request


          Docs: use consistent HTML elements in Utilities > Background page (tw…

8d76cd3

…bs#39519)

damian-snyk mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.1 to 5.3.3 damian-snyk/janus-pizza-fe#1

Open

CGrabda mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 CGrabda/drawBetterCards#18

Merged

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#393

Open

lukegeor mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.3 to 5.3.3 lukegeor/insecure-project-snyk#2

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#395

Open

This was referenced May 19, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 Identian/intra#5

Open

[Snyk] Upgrade bootstrap from 5.2.2 to 5.3.3 Identian/main#4

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#397

Open

Identian mentioned this pull request

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 Identian/del#2

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#399

Open

Hamberfim mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.3 to 5.3.3 Hamberfim/et4_webapp#6

Merged

V1CTORY360 mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.3 to 5.3.3 V1CTORY360/DatingApp#19

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#401

Open

This was referenced May 24, 2024

[Snyk] Upgrade bootstrap from 5.2.1 to 5.3.3 nejidevelops/Web-Development#26

Open

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 nejidevelops/soma-uhekimike#10

Open

devcurt696 mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.3 to 5.3.3 devcurt696/react-supabase-auth#75

Open

suryaelidanto mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.2 to 5.3.3 suryaelidanto/b43-payment-gateway-result#21

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#637

Open

DeFiTON mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 TegroTON/Tegro-Media-Source-project-file-for-SMM-Store#36

Open

lisagorewitdecker mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.0 to 5.3.3 lisagorewitdecker/Angular2023-to-1-2-Quarter-2024#669

Merged

YnnusAsamal mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 YnnusAsamal/TTI-NRL-WEB#3

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#639

Open

YnnusAsamal mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 YnnusAsamal/TTI-NRL-WEB#4

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#641

Open

Akhamesra mentioned this pull request

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 Akhamesra/glpi#5

Open

This was referenced Oct 2, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#643

Open

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#645

Open

YnnusAsamal mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 YnnusAsamal/TTI-NRL-WEB#5

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#647

Open

jtprogru mentioned this pull request

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 jtprogru/s11l.me#33

Open

Gutts-n mentioned this pull request

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 datopian/ckan#3

Open

Kimahari mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.0 to 5.3.3 Kimahari/nginx-dotnetcore-proxy#73

Merged

This was referenced Oct 5, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#649

Open

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#651

Open

This was referenced Oct 12, 2024

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/Vf#2

Open

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/Adminkit#2

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#653

Open

This was referenced Oct 15, 2024

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/vf-#2

Open

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/adminkit1#1

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#655

Open

Sarrac3873 mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 Sarrac3873/icu4x#5

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#657

Open

This was referenced Oct 29, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 TegroTON/Tegro-Media-Source-project-file-for-SMM-Store#37

Open

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 TegroTON/Tegro-Media-Source-project-file-for-SMM-Store#38

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#659

Open

Arrhenius09 mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.0 to 5.3.3 Arrhenius09/sonarqube-sample#2

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#661

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs enhancement v5