Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

twbs / bootstrap Public

Notifications You must be signed in to change notification settings
Fork 79.2k
Star 174k

Code
Issues 421
Pull requests 175
Discussions
Actions
Projects 2
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

Allow dl, dt and dd in sanitizer #39376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

julien-deramond merged 2 commits into twbs:main from Frenzie:dl

Nov 15, 2023

Merged

Allow dl, dt and dd in sanitizer #39376

julien-deramond merged 2 commits into twbs:main from Frenzie:dl

Nov 15, 2023

Conversation 3 Commits 2 Checks 0 Files changed

Uh oh!

There was an error while loading. Please reload this page.

Conversation

Copy link

Contributor

Frenzie commented Nov 7, 2023 •

edited by julien-deramond

Loading

Motivation & Context

These are inoffensive regular elements, along the same lines as ol/ul with li. Overriding the defaults for that seems silly.

Type of changes

(I guess it's somewhere in the middle.)

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (non-breaking change)
Breaking change (fix or feature that would change existing functionality)

Checklist

I have read the contributing guidelines
My code follows the code style of the project (using npm run lint)
My change introduces changes to the documentation
I have updated the documentation accordingly
I have added tests to cover my changes
All new and existing tests passed

Live previews

https://deploy-preview-39376--twbs-bootstrap.netlify.app/

Related issues

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Allow dl, dt and dd in sanitizer

966f330

These are inoffensive regular elements, along the same lines as ol/ul with li.

Frenzie requested a review from a team as a code owner

November 7, 2023 12:52

julien-deramond added js v5 labels

Copy link

Member

mdo commented Nov 13, 2023

Can't think of any reason to not include them. Thoughts @XhmikosR @GeoSot? Or @julien-deramond?

GeoSot reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mdo approved these changes

View reviewed changes

Copy link

Member

mdo left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving conditionally while waiting on feedback.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

julien-deramond approved these changes

View reviewed changes

Copy link

Member

julien-deramond left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, can't think of a reason to not include them.

I've found this draft W3C Standard Proposal > HTML Sanitizer API where there's a section named The Baseline Element Allow List. These elements are mentioned in it too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GeoSot, Frenzie, louismaximepiton, and mdo reacted with thumbs up emoji

All reactions

👍 4 reactions


          Merge branch 'main' into dl

270969b

julien-deramond merged commit b9f92d7 into twbs:main

Frenzie deleted the dl branch

November 15, 2023 08:20

romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request


          Allow <dl>, <dt> and <dd> in JS sanitizer (twbs#39376)

a47c342

Co-authored-by: Julien Déramond <juderamond@gmail.com>

damian-snyk mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.1 to 5.3.3 damian-snyk/janus-pizza-fe#1

Open

CGrabda mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 CGrabda/drawBetterCards#18

Merged

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#393

Open

lukegeor mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.3 to 5.3.3 lukegeor/insecure-project-snyk#2

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#395

Open

This was referenced May 19, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 Identian/intra#5

Open

[Snyk] Upgrade bootstrap from 5.2.2 to 5.3.3 Identian/main#4

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#397

Open

Identian mentioned this pull request

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 Identian/del#2

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#399

Open

Hamberfim mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.3 to 5.3.3 Hamberfim/et4_webapp#6

Merged

V1CTORY360 mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.3 to 5.3.3 V1CTORY360/DatingApp#19

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#401

Open

This was referenced May 24, 2024

[Snyk] Upgrade bootstrap from 5.2.1 to 5.3.3 nejidevelops/Web-Development#26

Open

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 nejidevelops/soma-uhekimike#10

Open

devcurt696 mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.3 to 5.3.3 devcurt696/react-supabase-auth#75

Open

suryaelidanto mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.2 to 5.3.3 suryaelidanto/b43-payment-gateway-result#21

Open

nejidevelops mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 nejidevelops/bratipah#11

Open

Guiguiiz92 mentioned this pull request

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 Guiguiiz92/openclassrooms-piiquante-project6#201

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#637

Open

DeFiTON mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 TegroTON/Tegro-Media-Source-project-file-for-SMM-Store#36

Open

lisagorewitdecker mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.0 to 5.3.3 lisagorewitdecker/Angular2023-to-1-2-Quarter-2024#669

Merged

YnnusAsamal mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 YnnusAsamal/TTI-NRL-WEB#3

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#639

Open

YnnusAsamal mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 YnnusAsamal/TTI-NRL-WEB#4

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#641

Open

Akhamesra mentioned this pull request

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 Akhamesra/glpi#5

Open

This was referenced Oct 2, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#643

Open

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#645

Open

YnnusAsamal mentioned this pull request

[Snyk] Upgrade bootstrap from 5.2.0 to 5.3.3 YnnusAsamal/TTI-NRL-WEB#5

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#647

Open

jtprogru mentioned this pull request

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 jtprogru/s11l.me#33

Open

Gutts-n mentioned this pull request

[Snyk] Upgrade bootstrap from 5.1.3 to 5.3.3 datopian/ckan#3

Open

Kimahari mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.0 to 5.3.3 Kimahari/nginx-dotnetcore-proxy#73

Merged

This was referenced Oct 5, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#649

Open

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#651

Open

This was referenced Oct 12, 2024

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/Vf#2

Open

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/Adminkit#2

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#653

Open

This was referenced Oct 15, 2024

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/vf-#2

Open

[Snyk] Upgrade bootstrap from 5.3.0 to 5.3.3 eronisking/adminkit1#1

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#655

Open

Sarrac3873 mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 Sarrac3873/icu4x#5

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#657

Open

This was referenced Oct 29, 2024

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 TegroTON/Tegro-Media-Source-project-file-for-SMM-Store#37

Open

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 TegroTON/Tegro-Media-Source-project-file-for-SMM-Store#38

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#659

Open

Arrhenius09 mentioned this pull request

[Snyk] Upgrade bootstrap from 5.0.0 to 5.3.3 Arrhenius09/sonarqube-sample#2

Open

RatanaSenpai mentioned this pull request

[Snyk] Upgrade bootstrap from 5.3.2 to 5.3.3 RatanaSenpai/La_Panthere#661

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mdo mdo approved these changes

julien-deramond julien-deramond approved these changes

Assignees

No one assigned

Labels

Projects

No open projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.