fix(typing): put EllipsisType in LengthType union (#116)

lucascolley · FBruzzesi · web-flow · commit cb52dd223a05 · 2025-09-17T20:35:05.000+02:00
``` tests/integration_python/test_main_cli.py:1481: error: No overload variant of "IsList" matches argument type "EllipsisType" [call-overload] tests/integration_python/test_main_cli.py:1481: note: Possible overload variants: tests/integration_python/test_main_cli.py:1481: note: def IsList(self, *items: Any, check_order: bool = ..., length: int | tuple[int, int | Any] | None = ...) -> IsList tests/integration_python/test_main_cli.py:1481: note: def IsList(self, positions: dict[int, Any], length: int | tuple[int, int | Any] | None = ...) -> IsList ``` An ellipsis is a valid argument, as shown in the docs: https://dirty-equals.helpmanual.io/latest/types/sequence/?h=isl#dirty_equals.IsList. closes gh-110 --------- Co-authored-by: Francesco Bruzzesi <42817048+FBruzzesi@users.noreply.github.com>
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -91,7 +91,7 @@ jobs:
       run: mkdocs build --strict
 
     - name: store docs site
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: docs
         path: site
diff --git a/.github/workflows/upload-previews.yml b/.github/workflows/upload-previews.yml
@@ -21,7 +21,7 @@ jobs:
       - run: pip install click==8.0.4
       - run: pip install smokeshow
 
-      - uses: dawidd6/action-download-artifact@v2
+      - uses: dawidd6/action-download-artifact@v11
         with:
           workflow: ci.yml
           commit: ${{ github.event.workflow_run.head_sha }}
diff --git a/dirty_equals/_sequence.py b/dirty_equals/_sequence.py
@@ -1,3 +1,4 @@
+import sys
 from typing import TYPE_CHECKING, Any, Container, Dict, List, Optional, Sized, Tuple, Type, TypeVar, Union, overload
 
 from ._base import DirtyEquals
@@ -6,9 +7,14 @@
 if TYPE_CHECKING:
     from typing import TypeAlias
 
+if sys.version_info >= (3, 10):
+    from types import EllipsisType
+else:
+    EllipsisType = Any
+
 __all__ = 'HasLen', 'Contains', 'IsListOrTuple', 'IsList', 'IsTuple'
 T = TypeVar('T', List[Any], Tuple[Any, ...])
-LengthType: 'TypeAlias' = 'Union[None, int, Tuple[int, Union[int, Any]]]'
+LengthType: 'TypeAlias' = 'Union[None, int, Tuple[int, Union[int, Any]], EllipsisType]'
 
 
 class HasLen(DirtyEquals[Sized]):
