fix: login before pushing docker images in release pipeline (coder#2496)

deansheather · web-flow · commit 8d6faa3c1ab4 · 2022-06-19T13:12:09.000+10:00
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -43,6 +43,13 @@ jobs:
       - name: Fetch git tags
         run: git fetch --tags --force
 
+      - name: Docker Login
+        uses: docker/login-action@v2
+        with:
+          registry: ghcr.io
+          username: ${{ github.repository_owner }}
+          password: ${{ secrets.GITHUB_TOKEN }}
+
       - uses: actions/setup-go@v3
         with:
           go-version: "~1.18"
@@ -242,13 +249,6 @@ jobs:
       - name: Fetch git tags
         run: git fetch --tags --force
 
-      - name: Docker Login
-        uses: docker/login-action@v2
-        with:
-          registry: ghcr.io
-          username: ${{ github.repository_owner }}
-          password: ${{ secrets.GITHUB_TOKEN }}
-
       - name: mkdir artifacts
         run: mkdir artifacts
 
diff --git a/scripts/build_docker.sh b/scripts/build_docker.sh
@@ -109,7 +109,7 @@ rm -rf "$temp_dir"
 
 if [[ "$push" == 1 ]]; then
 	log "--- Pushing Docker image for $arch ($image_tag)"
-	docker push "$image_tag"
+	docker push "$image_tag" 1>&2
 fi
 
 echo "$image_tag"
