fix: Force keeping old files to prevent dpkg failure on update (coder#2399)

kylecarbs · web-flow · commit 10dc9e387627 · 2022-06-15T20:04:20.000-05:00
Updating a release if system files failed would result in failure from
the install script. This fixes it!
diff --git a/install.sh b/install.sh
@@ -329,7 +329,7 @@ install_deb() {
 
 	fetch "https://github.com/coder/coder/releases/download/v$VERSION/coder_${VERSION}_${OS}_${ARCH}.deb" \
 		"$CACHE_DIR/coder_${VERSION}_$ARCH.deb"
-	sudo_sh_c dpkg -i "$CACHE_DIR/coder_${VERSION}_$ARCH.deb"
+	sudo_sh_c dpkg --force-confdef --force-confold -i "$CACHE_DIR/coder_${VERSION}_$ARCH.deb"
 
 	echo_systemd_postinstall deb
 }
diff --git a/preinstall.sh b/preinstall.sh
@@ -6,6 +6,7 @@ USER="coder"
 # Add a Coder user to run as in systemd.
 if ! id -u $USER >/dev/null 2>&1; then
 	useradd \
+		--create-home \
 		--system \
 		--user-group \
 		--shell /bin/false \

Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,7 @@ install_deb() {`
`329`	`329`
`330`	`330`	`fetch "https://github.com/coder/coder/releases/download/v$VERSION/coder_${VERSION}_${OS}_${ARCH}.deb" \`
`331`	`331`	`"$CACHE_DIR/coder_${VERSION}_$ARCH.deb"`
`332`		`- sudo_sh_c dpkg -i "$CACHE_DIR/coder_${VERSION}_$ARCH.deb"`
	`332`	`+ sudo_sh_c dpkg --force-confdef --force-confold -i "$CACHE_DIR/coder_${VERSION}_$ARCH.deb"`
`333`	`333`
`334`	`334`	`echo_systemd_postinstall deb`
`335`	`335`	`}`