feat: restore NETLIFY_NEXT_PLUGIN_SKIP #3017
Conversation
|
Instead of checking for the same condition in every event handler, I could have also checked this once and conditonally return the event handlers as documented here: https://docs.netlify.com/extend/develop-and-share/develop-build-plugins/#dynamic-events, but I thought that might be a bigger change. I am still open to change it into that, so let me know. |
| @@ -53,6 +65,11 @@ export const onPreBuild = async (options: NetlifyPluginOptions) => { | |||
| } | |||
|
|
|||
| export const onBuild = async (options: NetlifyPluginOptions) => { | |||
| if (skipPlugin) { | |||
| console.warn(skipText) | |||
There was a problem hiding this comment.
We will repeat skipText quite a bit for each hook. For comparison v4 did omit logs/warnings in some of hooks like
opennextjs-netlify/packages/runtime/src/index.ts
Lines 98 to 100 in 526cd4e
I think it's fine as-is and we can maybe change this later if we think it's too spammy in practice, but more important is to restore ability to skip, so let's ship this
Description
Next.js Runtime v4 offered NETLIFY_NEXT_PLUGIN_SKIP environment variable that could be used to skip any work done by Next.js Runtime on Netlify. In v5, this variable was removed. However, there are still some use-cases which could require this to be explicitly set.
Documentation
No documentation changes. Feel free to let me know what needs to be updated and I'll do that.
Tests
No tests added, since this appeared to be a fairly simple change? I could be wrong but I'm also not sure what to test for here.
Relevant links (GitHub issues, etc.) or a picture of cute animal
https://linear.app/netlify/issue/FRB-1952/