Bearer token provider addition to openaiclient #2470
+262
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low bearer tokens to be updated
… Propagate bearer_token_provider in the `copy` method.
* add tests, fix copy, add token provider to module client * fix lint * ignore for azure copy * revert change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Adding a way for the caller to provide (and refresh) bearer tokens. Similar to what is already supported for the Azure OpenAI client, but with a more generic name.
Additional context & links
The PR allows for callers to asynchronously fetch (and update) bearer tokens. This covers a broad spectrum of auth scenarios, including api key refresh and oauth assuming no service challenge information is needed to retrieve the token (rare).
It would not cover scenarios where the request body is needed (e.g. request signing) or where information from a challenge is needed.