fix(client): correctly marshal text/plain requests
#1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in #1914, there are cases where trying to interact with a `text/plain` endpoint that requires input, for instance when receiving a UUID, may not render correctly. We should first check if the type is a `Stringer`, aka has a `String()` method, and use that - otherwise use `fmt.Sprintf("%v", ...)` to generate a string type. Via [0], we can make sure that we wrap the generated type in an empty `interface`, so we can perform the type assertion. This also adds a test case to validate the functionality for: - a UUID, which has a `String()` method - a `float32`, which is a primitive datatype that needs to use `fmt.Sprintf` Co-authored-by: claude-sonnet:3.7-thinking <github-copilot@jamietanna.co.uk> Closes #1914. [0]: https://www.jvt.me/posts/2025/05/10/go-type-assertion-concrete/
| if stringer, ok := interface{}(body).(fmt.Stringer); ok { | ||
| bodyReader = strings.NewReader(stringer.String()) | ||
| } else { | ||
| bodyReader = strings.NewReader(fmt.Sprintf("%v", body)) |
There was a problem hiding this comment.
Suggested change
| bodyReader = strings.NewReader(fmt.Sprintf("%v", body)) | |
| bodyReader = strings.NewReader(fmt.Sprint(body)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1914, there are cases where trying to interact with a
text/plainendpoint that requires input, for instance when receiving aUUID, may not render correctly.
We should first check if the type is a
Stringer, aka has aString()method, and use that - otherwise use
fmt.Sprintf("%v", ...)togenerate a string type.
Via 0, we can make sure that we wrap the generated type in an empty
interface, so we can perform the type assertion.This also adds a test case to validate the functionality for:
String()methodfloat32, which is a primitive datatype that needs to usefmt.SprintfCo-authored-by: claude-sonnet:3.7-thinking
Closes #1914.