Skip to content

lib: fix inspect deduplication logic #59687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 11 commits into from
Sep 21, 2025
Merged

lib: fix inspect deduplication logic #59687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
70e89c4
lib: update inspect output format for subclasses
miguelmarcondesf Aug 30, 2025
de5c769
test: add inspect tests for null constructor scenarios
miguelmarcondesf Aug 30, 2025
f9306e7
test: update syntax error assertion in ESM loader test
miguelmarcondesf Aug 30, 2025
6122451
lib: revert tag exclusion for getClassBase
miguelmarcondesf Sep 1, 2025
6fa46c4
lib: revert tag exclusion for getFunctionBase
miguelmarcondesf Sep 1, 2025
26a46ae
test: rename subclasses for Map and Promise in inspect tests
miguelmarcondesf Sep 5, 2025
4daec61
lib: Update lib/internal/util/inspect.js
miguelmarcondesf Sep 13, 2025
a5fc528
test: enhance util.inspect assertions
miguelmarcondesf Sep 13, 2025
f38e4e8
lib: fix an off by one error
miguelmarcondesf Sep 19, 2025
0b314ef
lib: enhance error formatting in util.inspect
miguelmarcondesf Sep 19, 2025
a3816c8
lib: remove unnecessary error formatting
miguelmarcondesf Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib: update inspect output format for subclasses
  • Loading branch information
@miguelmarcondesf
miguelmarcondesf committed Sep 19, 2025
commit 70e89c40341a262bc13d041a46887f81972f8110
6 changes: 3 additions & 3 deletions lib/internal/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@ function getPrefix(constructor, tag, fallback, size = '') {
return `[${fallback}${size}: null prototype] `;
}

if (tag !== '' && constructor !== tag) {
if (tag !== '' && !constructor.includes(tag)) {
return `${constructor}${size} [${tag}] `;
}
return `${constructor}${size} `;
Expand Down Expand Up @@ -1507,7 +1507,7 @@ function getClassBase(value, constructor, tag) {
if (constructor !== 'Function' && constructor !== null) {
base += ` [${constructor}]`;
}
if (tag !== '' && constructor !== tag) {
if (tag !== '' && (constructor === null || !constructor.includes(tag))) {
base += ` [${tag}]`;
}
if (constructor !== null) {
Expand Down Expand Up @@ -1554,7 +1554,7 @@ function getFunctionBase(ctx, value, constructor, tag) {
if (constructor !== type && constructor !== null) {
base += ` ${constructor}`;
}
if (tag !== '' && constructor !== tag) {
if (tag !== '' && (constructor === null || !constructor.includes(tag))) {
base += ` [${tag}]`;
}
return base;
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-util-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,11 +1415,11 @@ if (typeof Symbol !== 'undefined') {
assert.strictEqual(util.inspect(new ArraySubclass(1, 2, 3)),
'ArraySubclass(3) [ 1, 2, 3 ]');
assert.strictEqual(util.inspect(new SetSubclass([1, 2, 3])),
'SetSubclass(3) [Set] { 1, 2, 3 }');
'SetSubclass(3) { 1, 2, 3 }');
assert.strictEqual(util.inspect(new MapSubclass([['foo', 42]])),
"MapSubclass(1) [Map] { 'foo' => 42 }");
"MapSubclass(1) { 'foo' => 42 }");
assert.strictEqual(util.inspect(new PromiseSubclass(() => {})),
'PromiseSubclass [Promise] { <pending> }');
'PromiseSubclass { <pending> }');
assert.strictEqual(util.inspect(new SymbolNameClass()),
'Symbol(name) {}');
assert.strictEqual(
Expand Down