Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: modelcontextprotocol/typescript-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: modelcontextprotocol/typescript-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr-652
Choose a head ref
  • 17 commits
  • 4 files changed
  • 3 contributors

Commits on Jul 18, 2025

  1. feat: support oidc discovery in client sdk

    @xiaoyijun
    xiaoyijun committed Jul 18, 2025
    Configuration menu
    Copy the full SHA
    be90ac5 View commit details
    Browse the repository at this point in the history

  2. chore: rebased

    @xiaoyijun
    xiaoyijun committed Jul 18, 2025
    Configuration menu
    Copy the full SHA
    3bb5f3e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2025

  1. feat: apply draft spec

    @xiaoyijun
    xiaoyijun committed Jul 19, 2025
    Configuration menu
    Copy the full SHA
    5375f46 View commit details
    Browse the repository at this point in the history

  2. chore: revert tests

    @xiaoyijun
    xiaoyijun committed Jul 19, 2025
    Configuration menu
    Copy the full SHA
    997b850 View commit details
    Browse the repository at this point in the history

  3. test: add unit tests

    @xiaoyijun
    xiaoyijun committed Jul 19, 2025
    Configuration menu
    Copy the full SHA
    69619b9 View commit details
    Browse the repository at this point in the history

  4. chore: revert format changes

    @xiaoyijun
    xiaoyijun committed Jul 19, 2025
    Configuration menu
    Copy the full SHA
    c148ef1 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2025

  1. feat: add S256 PKCE validation for OIDC discovery 

    Adds validation during OIDC provider discovery to ensure S256 code
challenge method is supported as required by MCP specification.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
    @pcarleton @claude
    pcarleton and claude committed Jul 23, 2025
    Configuration menu
    Copy the full SHA
    ecb76f1 View commit details
    Browse the repository at this point in the history

  2. refactor: restore original fallback behavior in discovery 

    Moves fallback logic back to individual functions instead of
generating "fake" metadata during discovery. Discovery now returns
undefined on 404 like the original code, maintaining the existing
architectural pattern where functions handle their own URL fallbacks.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
    @pcarleton @claude
    pcarleton and claude committed Jul 23, 2025
    Configuration menu
    Copy the full SHA
    7734124 View commit details
    Browse the repository at this point in the history

  3. feat: add root OAuth discovery fallback with RFC compliance 

    Implements root OAuth discovery fallback when path-aware discovery fails,
restoring compatibility behavior from original code. Adds comprehensive
RFC documentation for OAuth 2.0 Authorization Server Metadata (RFC 8414)
and OpenID Connect Discovery 1.0 path handling rules.

Discovery sequence for issuer with path components:
1. OAuth with path insertion (RFC 8414 Section 3.1)
2. OIDC with path insertion (RFC 8414 Section 5 compatibility)
3. OIDC with path appending (OIDC Discovery 1.0 Section 4.1)
4. OAuth root fallback for compatibility

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
    @pcarleton @claude
    pcarleton and claude committed Jul 23, 2025
    Configuration menu
    Copy the full SHA
    4f6b5ad View commit details
    Browse the repository at this point in the history

  4. refactor: revise discovery order for consistency 

    Changes discovery sequence to be more logical and consistent:
1. Path-aware OAuth discovery
2. Root OAuth discovery (if path exists)
3. OIDC discovery methods

This ensures OAuth methods are exhausted before trying OIDC,
providing more predictable fallback behavior.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
    @pcarleton @claude
    pcarleton and claude committed Jul 23, 2025
    Configuration menu
    Copy the full SHA
    7065c38 View commit details
    Browse the repository at this point in the history

  5. test: remove redundant discovery tests 

    Removes tests that are now covered by the parameterized discovery
sequence tests, eliminating duplication while maintaining full
coverage of all discovery scenarios.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
    @pcarleton @claude
    pcarleton and claude committed Jul 23, 2025
    Configuration menu
    Copy the full SHA
    fdc147e View commit details
    Browse the repository at this point in the history

  6. clean up unused param

    @pcarleton
    pcarleton committed Jul 23, 2025
    Configuration menu
    Copy the full SHA
    c8ccd03 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2025

  1. simplify fetching logic

    @pcarleton
    pcarleton committed Jul 24, 2025
    Configuration menu
    Copy the full SHA
    90f6eca View commit details
    Browse the repository at this point in the history

  2. test discovery urls list

    @pcarleton
    pcarleton committed Jul 24, 2025
    Configuration menu
    Copy the full SHA
    49b51f5 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @pcarleton
    pcarleton committed Jul 24, 2025
    Configuration menu
    Copy the full SHA
    0b2c0b1 View commit details
    Browse the repository at this point in the history

  4. simplify path construction

    @pcarleton
    pcarleton committed Jul 24, 2025
    Configuration menu
    Copy the full SHA
    ab060e1 View commit details
    Browse the repository at this point in the history

  5. permit all 4xx status codes to continue probing

    @pcarleton
    pcarleton committed Jul 24, 2025
    Configuration menu
    Copy the full SHA
    a6fd8f5 View commit details
    Browse the repository at this point in the history
Loading