-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
tests: various improvements for Octoprobe (WIP) #17782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dpgeorge
wants to merge
17
commits into
micropython:master
Choose a base branch
from
dpgeorge:tests-improvements-for-octoprobe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
tests: various improvements for Octoprobe (WIP) #17782
dpgeorge
wants to merge
17
commits into
micropython:master
from
dpgeorge:tests-improvements-for-octoprobe
+123
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17782 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 171 171
Lines 22283 22283
=======================================
Hits 21924 21924
Misses 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
18ad8c0
to
5958518
Compare
Code size report:
|
c399b93
to
ca374fa
Compare
@dpgeorge: Two easy to reproduce bugs which could be added to ths PR |
ca374fa
to
aee37bb
Compare
Signed-off-by: Damien George <damien@micropython.org>
Some boards define ESP32C3, some define ESP32-C3. Probably it should just use default pins, eg SPI(1). Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Some tests (currently given by the `special_tests` list) have output which must be mached via a regex, because it can change from run to run (eg the address of an object is printed). These tests are currently classified as `is_special` in the test runner, which means they get special treatment. In particular they don't set the emitter as specified by `args.emit`. That means these tests do not run via .mpy or using the native emitter, even if those options are given on the command line. This commit fixes that by considering `is_special` as different to `tests_with_regex_output`. The former is used for things like target feature detection (which are not really tests) and when extra command line options need to be passed to the unix micropython executable. The latter (now called `tests_with_regex_output`) are specifically for tests that have output to be matched via regex. The `thread_exc2.py` test now needs to be excluded when running using the native emitter, because the native emitter doesn't print traceback info. And the `sys_settrace_cov.py` test needs to be excluded because set-trace output is different with the native emitter. Signed-off-by: Damien George <damien@micropython.org>
To get `micropython/extreme_exc.py` to pass when run via-mpy. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Eg for ESP8266-512K. Signed-off-by: Damien George <damien@micropython.org>
In --via-mpy --emit native mode. Signed-off-by: Damien George <damien@micropython.org>
On ESP8266 this test can fail with --via-mpy. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Because RP2350 uses float-abi=softfp! Maybe we should change that somehow? Could also use `defined(__SOFTFP__)` to detect soft (all software fp) or softfp (hardware for calculations but soft/integer for passing arguments). Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Tested on ADAFRUIT_ITSYBITSY_M0_EXPRESS. Signed-off-by: Damien George <damien@micropython.org>
On RP2350 these must now be skipped with via-mpy, due to mpy-cross not knowing the correct architecture. Signed-off-by: Damien George <damien@micropython.org>
aee37bb
to
8920560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a collection of various small improvements to the test suite to get Octoprobe to pass more of the tests.
Once fully working, these changes will be made into separate PRs.
Testing
To be tested by Octoprobe: https://reports.octoprobe.org/
Test report prior to this PR: https://reports.octoprobe.org/github_selfhosted_testrun_194/octoprobe_summary_report.html
Test report with this PR: https://reports.octoprobe.org/github_selfhosted_testrun_199/octoprobe_summary_report.html