-
-
Notifications
You must be signed in to change notification settings - Fork 217
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Hello! I've noticed that the groupby()
typings for dataframes do not follow the intended implementation of the groupby()
function.
The documentation here:
https://github.com/opensource9ja/danfojs/blob/146ba82ca723527f5c2008b5077c6a13d196e01f/danfojs-browser/src/core/frame.js#L2310
states that the col
parameter is a list of (string) columns, while the typing here:
https://github.com/opensource9ja/danfojs/blob/146ba82ca723527f5c2008b5077c6a13d196e01f/danfojs-browser/types/core/frame.d.ts#L554
declares that the function only takes in a string value. This will probably lead to errors when used, since string values are not mappable.
Also, perhaps this parameter can be made optional by allowing it to be undefined?
risenW
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working