Skip to content

Commit 0db5981

Browse files
dwightjackdwightjack
authored
chore: remove aria-hidden attribute in Iconify component (unovue#888)
* docs(accordion): fix aria-hidden attribute in examples * docs: remove aria-hidden because it's already applied by iconify component
1 parent af7257e commit 0db5981

File tree

9 files changed

+2
-23
lines changed

9 files changed

+2
-23
lines changed

‎docs/components/demo/Accordion/css/index.vue‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const accordionItems = [
3434
<AccordionHeader class="AccordionHeader">
3535
<AccordionTrigger class="AccordionTrigger">
3636
<span>{{ item.title }}</span>
37-
<Icon icon="radix-icons:chevron-down" class="AccordionChevron" aria-hidden />
37+
<Icon icon="radix-icons:chevron-down" class="AccordionChevron" />
3838
</AccordionTrigger>
3939
</AccordionHeader>
4040
<AccordionContent class="AccordionContent">

‎docs/components/demo/Accordion/tailwind/index.vue‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ const accordionItems = [
3636
<Icon
3737
icon="radix-icons:chevron-down"
3838
class="text-green10 ease-[cubic-bezier(0.87,_0,_0.13,_1)] transition-transform duration-300 group-data-[state=open]:rotate-180"
39-
aria-hidden
4039
/>
4140
</AccordionTrigger>
4241
</AccordionHeader>

‎docs/components/demo/NavigationMenu/css/index.vue‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ const currentTrigger = ref('')
2929
<Icon
3030
icon="radix-icons:caret-down"
3131
class="CaretDown"
32-
aria-hidden
3332
/>
3433
</NavigationMenuTrigger>
3534
<NavigationMenuContent
@@ -70,7 +69,6 @@ const currentTrigger = ref('')
7069
<Icon
7170
icon="radix-icons:caret-down"
7271
class="CaretDown"
73-
aria-hidden
7472
/>
7573
</NavigationMenuTrigger>
7674
<NavigationMenuContent class="NavigationMenuContent">

‎docs/components/demo/NavigationMenu/tailwind/index.vue‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ const currentTrigger = ref('')
2727
<Icon
2828
icon="radix-icons:caret-down"
2929
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
30-
aria-hidden
3130
/>
3231
</NavigationMenuTrigger>
3332
<NavigationMenuContent
@@ -68,7 +67,6 @@ const currentTrigger = ref('')
6867
<Icon
6968
icon="radix-icons:caret-down"
7069
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
71-
aria-hidden
7270
/>
7371
</NavigationMenuTrigger>
7472
<NavigationMenuContent class="data-[motion=from-start]:animate-enterFromLeft data-[motion=from-end]:animate-enterFromRight data-[motion=to-start]:animate-exitToLeft data-[motion=to-end]:animate-exitToRight absolute top-0 left-0 w-full sm:w-auto">

‎docs/content/components/accordion.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ import './styles.css'
235235
<AccordionHeader>
236236
<AccordionTrigger class="AccordionTrigger">
237237
<span>Trigger text</span>
238-
<Icon icon="radix-icons:chevron-down" class="AccordionChevron" aria-hidden />
238+
<Icon icon="radix-icons:chevron-down" class="AccordionChevron" />
239239
</AccordionTrigger>
240240
</AccordionHeader>
241241
<AccordionContent>…</AccordionContent>

‎packages/radix-vue/src/NavigationMenu/story/NavigationMenuBasic.story.vue‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ const state = reactive({
4040
<Icon
4141
icon="radix-icons:caret-down"
4242
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
43-
aria-hidden
4443
/>
4544
</NavigationMenuTrigger>
4645

@@ -68,7 +67,6 @@ const state = reactive({
6867
<Icon
6968
icon="radix-icons:caret-down"
7069
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
71-
aria-hidden
7270
/>
7371
</NavigationMenuTrigger>
7472
<NavigationMenuContent
@@ -92,7 +90,6 @@ const state = reactive({
9290
<Icon
9391
icon="radix-icons:caret-down"
9492
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
95-
aria-hidden
9693
/>
9794
</NavigationMenuTrigger>
9895
<NavigationMenuContent

‎packages/radix-vue/src/NavigationMenu/story/NavigationMenuDemo.story.vue‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ const currentTrigger = ref('')
3535
<Icon
3636
icon="radix-icons:caret-down"
3737
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
38-
aria-hidden
3938
/>
4039
</NavigationMenuTrigger>
4140
<NavigationMenuContent
@@ -104,7 +103,6 @@ const currentTrigger = ref('')
104103
<Icon
105104
icon="radix-icons:caret-down"
106105
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
107-
aria-hidden
108106
/>
109107
</NavigationMenuTrigger>
110108
<NavigationMenuContent

‎packages/radix-vue/src/NavigationMenu/story/NavigationMenuSubmenus.story.vue‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ const currentTrigger = ref('')
3737
<Icon
3838
icon="radix-icons:caret-down"
3939
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
40-
aria-hidden
4140
/>
4241
</NavigationMenuTrigger>
4342

@@ -59,7 +58,6 @@ const currentTrigger = ref('')
5958
<Icon
6059
icon="radix-icons:caret-down"
6160
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
62-
aria-hidden
6361
/>
6462
</NavigationMenuTrigger>
6563

@@ -87,7 +85,6 @@ const currentTrigger = ref('')
8785
<Icon
8886
icon="radix-icons:caret-down"
8987
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
90-
aria-hidden
9188
/>
9289
</NavigationMenuTrigger>
9390
<NavigationMenuContent
@@ -111,7 +108,6 @@ const currentTrigger = ref('')
111108
<Icon
112109
icon="radix-icons:caret-down"
113110
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
114-
aria-hidden
115111
/>
116112
</NavigationMenuTrigger>
117113
<NavigationMenuContent
@@ -145,7 +141,6 @@ const currentTrigger = ref('')
145141
<Icon
146142
icon="radix-icons:caret-down"
147143
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
148-
aria-hidden
149144
/>
150145
</NavigationMenuTrigger>
151146
<NavigationMenuContent
@@ -168,7 +163,6 @@ const currentTrigger = ref('')
168163
<Icon
169164
icon="radix-icons:caret-down"
170165
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
171-
aria-hidden
172166
/>
173167
</NavigationMenuTrigger>
174168

@@ -196,7 +190,6 @@ const currentTrigger = ref('')
196190
<Icon
197191
icon="radix-icons:caret-down"
198192
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
199-
aria-hidden
200193
/>
201194
</NavigationMenuTrigger>
202195
<NavigationMenuContent
@@ -220,7 +213,6 @@ const currentTrigger = ref('')
220213
<Icon
221214
icon="radix-icons:caret-down"
222215
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
223-
aria-hidden
224216
/>
225217
</NavigationMenuTrigger>
226218
<NavigationMenuContent

‎packages/radix-vue/src/NavigationMenu/story/NavigationMenuViewport.story.vue‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ const currentTrigger = ref('')
3636
<Icon
3737
icon="radix-icons:caret-down"
3838
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
39-
aria-hidden
4039
/>
4140
</NavigationMenuTrigger>
4241

@@ -64,7 +63,6 @@ const currentTrigger = ref('')
6463
<Icon
6564
icon="radix-icons:caret-down"
6665
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
67-
aria-hidden
6866
/>
6967
</NavigationMenuTrigger>
7068
<NavigationMenuContent
@@ -88,7 +86,6 @@ const currentTrigger = ref('')
8886
<Icon
8987
icon="radix-icons:caret-down"
9088
class="text-green10 relative top-[1px] transition-transform duration-[250ms] ease-in group-data-[state=open]:-rotate-180"
91-
aria-hidden
9289
/>
9390
</NavigationMenuTrigger>
9491
<NavigationMenuContent

0 commit comments

Comments
 (0)