Skip to content

[elastic_package_registry] First iteration to support multi-instance data in dashboards #4080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrodm merged 14 commits into from
Sep 13, 2022
Merged

[elastic_package_registry] First iteration to support multi-instance data in dashboards #4080

mrodm merged 14 commits into from
Sep 13, 2022

Conversation

@mrodm
Copy link
Collaborator

@mrodm mrodm commented Aug 26, 2022 •
edited
Loading

What does this PR do?

Update elastic_package_registry dashboard to support showing data when there are several instances of the service configured in the integration.

  • Add selector to narrow the data according to the instances selected
  • Update README following the guidelines
  • Update visualizations/lens to show all the values from each instance (version, uptime, indexed packages)
  • Reviewed functions used in panels (sum, avg)
  • Update manifest to use elastic.subscription condition.

There are some lens as "EPR Version" or "EPR Number of Indexed packages" that are affected by the global filters (or controls) (issue related elastic/kibana#140204)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Run elastic-package stack up -v -d --version 8.0.0 to boot the whole Elastic stack
  • Go to the elastic_package_registry folder and boot the service: 
    cd packages/elastic_package_registry
elastic-package service up -v
  • Go to kibana (https://localhost:5601) and configure this integration with these settings:

Related issues

Screenshots

  • Overview:
    elastic_package_registry-metrics-overview

  • Overview selecting one instance:

elastic_package_registry-metrics-overview-service

@mrodm mrodm added the enhancement New feature or request label Aug 26, 2022
@mrodm mrodm self-assigned this Aug 26, 2022
@elasticmachine
Copy link

elasticmachine commented Aug 26, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-13T12:03:50.161+0000

  • Duration: 13 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 26, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.703
Classes 100.0% (1/1) 💚 2.703
Methods 100.0% (8/8) 💚 10.276
Lines 100.0% (77/77) 💚 8.611
Conditionals 100.0% (0/0) 💚

@mrodm mrodm force-pushed the epr_dashboard_multiinstance branch from 5491441 to 4fd7ea8 Compare September 9, 2022 09:11
@mrodm mrodm force-pushed the epr_dashboard_multiinstance branch from 9b73e76 to ed4aa43 Compare September 9, 2022 16:57
@mrodm mrodm changed the title [elastic_package_registry] Support multi-instance data in dashboards [elastic_package_registry] First iteration to support multi-instance data in dashboards Sep 9, 2022
@mrodm mrodm added the Team:Ecosystem Packages Ecosystem team [elastic/ecosystem] label Sep 12, 2022
@mrodm mrodm marked this pull request as ready for review September 12, 2022 13:26
@mrodm mrodm requested a review from a team as a code owner September 12, 2022 13:26
@jsoriano
Copy link
Member

jsoriano commented Sep 12, 2022 •
edited
Loading

There are some lens as "EPR Version" or "EPR Number of Indexed packages" that are affected by the global filters (or controls) (issue related elastic/kibana#140204)

It looks like you are not using controls to select the instance. Is it because this issue or there is some other problem?

@mrodm
Copy link
Collaborator Author

mrodm commented Sep 12, 2022

There are some lens as "EPR Version" or "EPR Number of Indexed packages" that are affected by the global filters (or controls) (issue related elastic/kibana#140204)

It looks like you are not using controls to select the instance. Is it because this issue or there is some other problem?

There is a selector for the instance in the Controls. The control to select those is named "Service address".

Do you think it would be better to change that selector/control to "Instance" ?

@jsoriano
Copy link
Member

jsoriano commented Sep 12, 2022

There is a selector for the instance in the Controls. The control to select those is named "Service address".

Oh ok, I thought that instances were selected by clicking on them on one of the three tables on top.

Do you think it would be better to change that selector/control to "Instance" ?

Yes, this could be better, as we are calling this "instances" in other parts of the dashboard.

Another thing that I think confused me is that we have the controls below other views, I would expect controls affecting these views to be on top of them.

But all these are details, so as you prefer 🙂

@mtojek mtojek self-requested a review September 13, 2022 08:06
mtojek
mtojek approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect dashboards :)

@mrodm
Copy link
Collaborator Author

mrodm commented Sep 13, 2022

Re-ordered control to be at the top of the dashboard. And renamed the control that allows selecting instances (from "Service Address" to be "Instances").

@mrodm mrodm merged commit d7c84e4 into elastic:main Sep 13, 2022
@mrodm mrodm deleted the epr_dashboard_multiinstance branch September 13, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano jsoriano approved these changes

+1 more reviewer

@mtojek mtojek mtojek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mrodm mrodm

Labels

enhancement New feature or request Team:Ecosystem Packages Ecosystem team [elastic/ecosystem]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrodm @elasticmachine @jsoriano @mtojek