feat: support OTel span.addLink, span.addLinks; add similar APIs to the APM agent API #4078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-luna
previously approved these changes
Jun 12, 2024
Member
david-luna
left a comment
There was a problem hiding this comment.
Thanks for this PR. I went too quick bumping the OTEL API package :)
All looks good, just couple of comments about types
david-luna
approved these changes
Jun 13, 2024
PeterEinberger
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
…he APM agent API (elastic#4078) This also updates a few places for the new otel/api v1.9.0. Refs: elastic#4071 (the dependabot update doesn't get everything) Refs: elastic#4070 Refs: elastic#4069 Refs: elastic#4077 (a separate issue for this other new feature in otel/api@1.9.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates a few places for the new otel/api v1.9.0.
Refs: #4071 (the dependabot update doesn't get everything)
Refs: #4070
Refs: #4069
Refs: #4077 (a separate issue for this other new feature in otel/api@1.9.0)
Refs: elastic/apm#870
@opentelemetry/api@1.9.0added support forspan.addLink()andspan.addLinks().This updates our OTel bridge tracing support to work with those APIs.
This also adds public
addLink()andaddLinks()equivalent methods on our Transaction and Span APIs.Note that the span links support still has limitations: only trace_id and span_id are sent/stored (no span link attributes, no 'tracestate' in the span context).
I created a separate issue for the other feature added to otel/api@1.9.0.