Skip to content

Merge | SqlDataReader #3259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

Merge | SqlDataReader #3259

merged 3 commits into from
Apr 10, 2025

Conversation

edwardneal
Copy link
Contributor

Fixes #2965.
Contributes to #1261.

This merges SqlDataReader. It might be worth reviewing each commit individually:

  • Commit 1 merges the contents of the files.
  • Commit 2 replaces the files and patches the XML documentation paths.
  • Commit 3 mops up two debug assertions and a comment.

Could someone run CI please?

@samsharma2700 samsharma2700 self-assigned this Apr 8, 2025
@samsharma2700 samsharma2700 requested a review from a team April 8, 2025 17:44
@paulmedynski paulmedynski self-assigned this Apr 8, 2025
@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benrr101 benrr101 added the Common Project 🚮 Things that relate to the common project project label Apr 8, 2025
@benrr101 benrr101 self-assigned this Apr 8, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.19%. Comparing base (1690e02) to head (e83f966).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ient/src/Microsoft/Data/SqlClient/SqlDataReader.cs 50.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1690e02) and HEAD (e83f966). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1690e02) HEAD (e83f966)
addons 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3259      +/-   ##
==========================================
- Coverage   72.83%   66.19%   -6.64%     
==========================================
  Files         298      290       -8     
  Lines       59675    56944    -2731     
==========================================
- Hits        43463    37693    -5770     
- Misses      16212    19251    +3039
Flag Coverage Δ
addons ?
netcore 68.95% <50.00%> (-6.30%) ⬇️
netfx 65.17% <78.57%> (-6.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle mdaigle added this to the 6.1-preview1 milestone Apr 10, 2025
@mdaigle mdaigle merged commit 89d5b8c into dotnet:main Apr 10, 2025
122 checks passed
@edwardneal edwardneal deleted the merge/sqldatareader branch April 10, 2025 19:32
This was referenced Jul 25, 2025
Open
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdaigle mdaigle mdaigle approved these changes

@paulmedynski paulmedynski paulmedynski approved these changes

Assignees

@benrr101 benrr101

@paulmedynski paulmedynski

@samsharma2700 samsharma2700

Labels
Common Project 🚮 Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

Work towards merging SqlDataReader
5 participants
@edwardneal @paulmedynski @mdaigle @benrr101 @samsharma2700