Skip to content

Cleanup | LocalDbApi #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 1, 2025
Merged

Cleanup | LocalDbApi #3182

merged 3 commits into from
Mar 1, 2025

Conversation

benrr101
Copy link
Contributor

Description: Putting a cap on the LocalDbApi merge projects, this is the last PR that applies cleanup to the merge. Most changes are pretty benign, mostly involving renaming LocalDBApi to LocalDbApi as per Microsoft standard C# naming conventions.

Testing: Local tests continue to run as per the usual, CI should validate the rest of it.

@benrr101 benrr101 added Code Health 💊 Issues/PRs that are targeted to source code quality improvements. Common Project 🚮 Things that relate to the common project project labels Feb 26, 2025
@benrr101 benrr101 added this to the 7.0-preview1 milestone Feb 26, 2025
@benrr101 benrr101 requested a review from a team February 26, 2025 18:51
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 8.00000% with 92 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (dcf6ac4) to head (a8c47dc).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...osoft/Data/SqlClient/LocalDb/LocalDbApi.Windows.cs 5.43% 87 Missing ⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 0.00% 2 Missing ⚠️
...ient/src/Microsoft/Data/SqlClient/SqlDependency.cs 0.00% 2 Missing ⚠️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3182      +/-   ##
==========================================
- Coverage   72.79%   72.75%   -0.05%     
==========================================
  Files         283      285       +2     
  Lines       59139    59156      +17     
==========================================
- Hits        43051    43037      -14     
- Misses      16088    16119      +31     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.45% <4.83%> (-0.08%) ⬇️
netfx 71.10% <8.16%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Health 💊 Issues/PRs that are targeted to source code quality improvements. Common Project 🚮 Things that relate to the common project project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants