Fix EmojiCompat crash when Entry bound to float with StringFormat #30791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
Fixes a crash that occurs when an
Entry
is bound to a float value with fractional string formatting (e.g.,{0:F2}
) on Android devices with EmojiCompat enabled.Problem
When users type in an
Entry
bound to a float withStringFormat='{}{0:F2}'
, the app crashes with:Root Cause: When a user types "1", the StringFormat converts it to "1.00", changing the text length from 1 to 4 characters. EmojiCompat gets confused about cursor positioning when
SetTextKeepState()
is called with the new text length, causing the crash.Reproduction:
Solution
Added a try-catch block around
SetTextKeepState()
in theUpdateTextFromPlatform()
method:SetTextKeepState()
works as before, preserving cursor positionsetText()
with manual cursor positioningBenefits
IllegalArgumentException
Testing
Added comprehensive test case
Issue25728
:Microsoft Docs
Fixes #25728.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.