Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: discourse/discourse
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main@{1day}
Choose a base ref
...
head repository: discourse/discourse
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 20 commits
  • 73 files changed
  • 14 contributors

Commits on Aug 11, 2025

  1. DEV: update various ai agent configurations (#34192) 

    Shortened AI agent file, so we conserve tokens
Use symlinks for all agent files where needed to avoid round trips to
llm
Added config for Open AI Codex / Gemini and Cursor
    @SamSaffron
    SamSaffron authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    e6f9cde View commit details
    Browse the repository at this point in the history

  2. FEATURE: Add previews to color palette selectors (#34129) 

    This commit adds a preview (same as the palette previews on the palette
list page `/admin/customize/colors`) to user's interface color palette
selectors, making it easy for users to see what a colour palette looks
like before they select it.

## Screenshot

<img width="696" height="563" alt="image"
src="/api/flow.js?q=https%3A%2F%2Fgithub.com%2Fdiscourse%2Fdiscourse%2Fcompare%2F%253Ca%2520href%3D"https://github.com/user-attachments/assets/ff598189-a1ba-4eb5-a7c1-cb1930ded6fc">https://github.com/user-attachments/assets/ff598189-a1ba-4eb5-a7c1-cb1930ded6fc"
/>
    @Lhcfl
    Lhcfl authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    e2d1d34 View commit details
    Browse the repository at this point in the history

  3. FIX: update final destination to use more recent user agent (#34207) 

    FD was using a user agent that is many years old so it is being flagged
as
an out of date browser
    @SamSaffron
    SamSaffron authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    4a17a31 View commit details
    Browse the repository at this point in the history

  4. DEV: remove experimental_sidebar_messages_count_enabled_groups (#34167) 

    Removes the temporary `experimental_sidebar_messages_count_enabled_groups` site setting.

Reverts #33774.
    @yuriyaran
    yuriyaran authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    f8ac0ba View commit details
    Browse the repository at this point in the history

  5. DEV: Unify reviewable action definition. (#34166) 

    This is a step towards unifying how reviewable types are defined.

In this change, we add a new `ReviewableActionBuilder` concern, which can be included by the various reviewable types to give them a standard helper for adding actions that can be performed on the reviewable.

The first feature for this concern takes the `build_action()` helper that some reviewables used, and makes it available to all reviewables. This is done in a backward compatible fashion, so it will work even whilst we transition to the new reviewable UI.
    @pento
    pento authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    7514dc8 View commit details
    Browse the repository at this point in the history

  6. FIX: user autocomplete search cache pollution (#34208) 

    The current chat autocomplete pipeline can mutate the user object
selected for autocomplete here:

https://github.com/discourse/discourse/blob/071e82140cf375e2875b87d1664ae596c19320dd/plugins/chat/assets/javascripts/discourse/components/chat-composer.gjs#L485

Specifically this occurs when we attempt to create a record in the store
service where it already exists, and the logic for fetching the right
record there deletes some properties from the input object:

https://github.com/discourse/discourse/blob/216df43502e25fcb9a228bfc09f90548712d7f49/app/assets/javascripts/discourse/app/services/store.js#L426-L435

This mutates the object that is eventually used to replace the search
term (and therefore causes an error as it is now missing all its
properties except for `id`). This also pollutes the upstream cache in
the userSearch JS module.

This PR fixes both issues by cloning the user objects before they get
passed into the processing functions.
    @tyb-talks
    tyb-talks authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    a71eb41 View commit details
    Browse the repository at this point in the history

  7. DEV: Remove automatic_backups_enabled setting (#33558) 

    We're removing the automatic_backups_enabled toggle and depending solely on the backup_frequency value. This PR replaces the setting and adds a migration for any forum that has automatic_backups_enabled disabled.
    @Drenmi
    Drenmi authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    f8bf514 View commit details
    Browse the repository at this point in the history

  8. UX: remove margin on user badge (#34216) 

    Reported on meta

https://meta.discourse.org/t/xxx-more-box-in-user-card-not-aligned/378031?mobile_view=1

This commit removes margin on `user-badge` class to avoid misalignment
on the usercard.

Only other instance I think uses this element is the admin badge page:
<img width="1015" height="581" alt="CleanShot 2025-08-11 at 11 32 05"
src="/api/flow.js?q=https%3A%2F%2Fgithub.com%2Fdiscourse%2Fdiscourse%2Fcompare%2F%253Ca%2520href%3D"https://github.com/user-attachments/assets/a55581f5-063d-476d-aea4-2ffee5d653c6">https://github.com/user-attachments/assets/a55581f5-063d-476d-aea4-2ffee5d653c6"
/>
Which also does not need that margin.
    @chapoi
    chapoi authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    a1dd82c View commit details
    Browse the repository at this point in the history

  9. Build(deps-dev): Bump @types/qunit from 2.19.12 to 2.19.13 in the typ… 

    …es group (#34197)

Bumps the types group with 1 update:
[@types/qunit](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/qunit).


Updates `@types/qunit` from 2.19.12 to 2.19.13
- [Release
notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
-
[Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/qunit)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    3879109 View commit details
    Browse the repository at this point in the history

  10. Build(deps-dev): Bump eslint from 9.32.0 to 9.33.0 in the lint group (#… 

    …34198)

Bumps the lint group with 1 update:
[eslint](https://github.com/eslint/eslint).


Updates `eslint` from 9.32.0 to 9.33.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.32.0...v9.33.0)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    14eb26d View commit details
    Browse the repository at this point in the history

  11. Build(deps): Bump regexp_parser from 2.11.0 to 2.11.1 (#34206) 

    Bumps [regexp_parser](https://github.com/ammar/regexp_parser) from
2.11.0 to 2.11.1.
-
[Changelog](https://github.com/ammar/regexp_parser/blob/master/CHANGELOG.md)
-
[Commits](ammar/regexp_parser@v2.11.0...v2.11.1)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    3d7eaab View commit details
    Browse the repository at this point in the history

  12. Build(deps-dev): Bump rubocop-rails from 2.32.0 to 2.33.0 (#34205) 

    Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from
2.32.0 to 2.33.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
-
[Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
-
[Commits](rubocop/rubocop-rails@v2.32.0...v2.33.0)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    567a3c8 View commit details
    Browse the repository at this point in the history

  13. Build(deps): Bump redis-client from 0.25.1 to 0.25.2 (#34203) 

    Bumps [redis-client](https://github.com/redis-rb/redis-client) from
0.25.1 to 0.25.2.
-
[Changelog](https://github.com/redis-rb/redis-client/blob/master/CHANGELOG.md)
-
[Commits](redis-rb/redis-client@v0.25.1...v0.25.2)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    @dependabot
    dependabot[bot] authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    33d58ef View commit details
    Browse the repository at this point in the history

  14. DEV: Convert InlineEditCheckbox to glimmer (#34030)

    @CvX
    CvX authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    f3c6260 View commit details
    Browse the repository at this point in the history

  15. DEV: Group fullcalendar dependency updates (#34217)

    @CvX
    CvX authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    24f0711 View commit details
    Browse the repository at this point in the history

  16. FIX: Improve filtering with multiple tag filters (#34120) 

    If you have a query like `category:1 tag:A,B tag:C,D` it should bring
all topics that are in category 1 and have tags (A or B) and (C or D).

Currently it works for `category:1 tag:A tag:C,D` -> it brings topics in
category 1 that have tag A and either (tag C OR tag D)
    @Grubba27
    Grubba27 authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    1f09720 View commit details
    Browse the repository at this point in the history

  17. FIX: Improve signup destination URL handling (#34221) 

    Use authOptions.destination_url instead of cookie and prevent redirect
loops to /signup

Internal ref t/160715
    @ZogStriP
    ZogStriP authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    4480c9c View commit details
    Browse the repository at this point in the history

  18. UX: Add unique class to user profile toggle button (#34223) 

    Adds a unique class for targeting this button directly.
    @sketchius
    sketchius authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    f804883 View commit details
    Browse the repository at this point in the history

  19. FIX: Showing errors during social auth in some edge cases (#34220) 

    Unable to repro this using tests, but can confirm with a local repro,
when the site is `login required`, the controller isn't present in the
router's promise. We should look it up.
    @pmusaraj
    pmusaraj authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    83197c9 View commit details
    Browse the repository at this point in the history

  20. DEV: Close footnote tooltip when trigger is removed (#34182) 

    This commit ensures inline footnote tooltips are closed when their trigger
element is removed from the page.

- Refactors inline footnotes to use a Glimmer component and DTooltip
- Replaces anchor triggers with components rendered via Glimmer
- Adds acceptance test to verify tooltip closes when link inside tooltip
is clicked
- Improves reliability of tooltip teardown on navigation or interaction
    @megothss
    megothss authored Aug 11, 2025
    Configuration menu
    Copy the full SHA
    168c4b7 View commit details
    Browse the repository at this point in the history
Loading