PECOBLR-86 improve logging on python driver (#556)

saishreeeee · varun-edachali-dbx · commit a5152d00b524 · 2025-05-28T03:40:34.000Z
* PECOBLR-86 Improve logging for debug level

Signed-off-by: Sai Shree Pradhan &lt;saishree.pradhan@databricks.com&gt;

* PECOBLR-86 Improve logging for debug level

Signed-off-by: Sai Shree Pradhan &lt;saishree.pradhan@databricks.com&gt;

* fixed format

Signed-off-by: Sai Shree Pradhan &lt;saishree.pradhan@databricks.com&gt;

* used lazy logging

Signed-off-by: Sai Shree Pradhan &lt;saishree.pradhan@databricks.com&gt;

* changed debug to error logs

Signed-off-by: Sai Shree Pradhan &lt;saishree.pradhan@databricks.com&gt;

* used lazy logging

Signed-off-by: Sai Shree Pradhan &lt;saishree.pradhan@databricks.com&gt;

---------

Signed-off-by: Sai Shree Pradhan &lt;saishree.pradhan@databricks.com&gt;
Signed-off-by: varun-edachali-dbx &lt;varun.edachali@databricks.com&gt;
diff --git a/src/databricks/sql/backend/thrift_backend.py b/src/databricks/sql/backend/thrift_backend.py
@@ -133,6 +133,13 @@ def __init__(
         # max_download_threads
         #  Number of threads for handling cloud fetch downloads. Defaults to 10
 
+        logger.debug(
+            "ThriftBackend.__init__(server_hostname=%s, port=%s, http_path=%s)",
+            server_hostname,
+            port,
+            http_path,
+        )
+
         port = port or 443
         if kwargs.get("_connection_uri"):
             uri = kwargs.get("_connection_uri")
@@ -404,6 +411,8 @@ def attempt_request(attempt):
 
                 # TODO: don't use exception handling for GOS polling...
 
+                logger.error("ThriftBackend.attempt_request: HTTPError: %s", err)
+
                 gos_name = TCLIServiceClient.GetOperationStatus.__name__
                 if method.__name__ == gos_name:
                     delay_default = (
@@ -448,6 +457,7 @@ def attempt_request(attempt):
                     else:
                         logger.warning(log_string)
             except Exception as err:
+                logger.error("ThriftBackend.attempt_request: Exception: %s", err)
                 error = err
                 retry_delay = extract_retry_delay(attempt)
                 error_message = (
@@ -914,6 +924,12 @@ def execute_command(
     ):
         assert session_handle is not None
 
+        logger.debug(
+            "ThriftBackend.execute_command(operation=%s, session_handle=%s)",
+            operation,
+            session_handle,
+        )
+
         spark_arrow_types = ttypes.TSparkArrowTypes(
             timestampAsArrow=self._use_arrow_native_timestamps,
             decimalAsArrow=self._use_arrow_native_decimals,
@@ -1150,6 +1166,7 @@ def fetch_results(
         return queue, resp.hasMoreRows
 
     def close_command(self, op_handle):
+        logger.debug("ThriftBackend.close_command(op_handle=%s)", op_handle)
         req = ttypes.TCloseOperationReq(operationHandle=op_handle)
         resp = self.make_request(self._client.CloseOperation, req)
         return resp.status
diff --git a/src/databricks/sql/client.py b/src/databricks/sql/client.py
@@ -216,6 +216,12 @@ def read(self) -> Optional[OAuthToken]:
         # use_cloud_fetch
         # Enable use of cloud fetch to extract large query results in parallel via cloud storage
 
+        logger.debug(
+            "Connection.__init__(server_hostname=%s, http_path=%s)",
+            server_hostname,
+            http_path,
+        )
+
         if access_token:
             access_token_kv = {"access_token": access_token}
             kwargs = {**kwargs, **access_token_kv}
@@ -745,6 +751,9 @@ def execute(
 
         :returns self
         """
+        logger.debug(
+            "Cursor.execute(operation=%s, parameters=%s)", operation, parameters
+        )
 
         param_approach = self._determine_parameter_approach(parameters)
         if param_approach == ParameterApproach.NONE:
