test: add Logger integration tests for headers.ts

jaggederest · claude · jaggederest · commit 53272c1dc584 · 2025-06-22T15:21:03.000-07:00
- Add tests verifying headers.ts works with Logger through interface
- Test error logging when header command fails
- Verify compatibility with Storage instance that has Logger set
- No code changes needed - headers.ts already uses Logger interface

The headers.ts module already supports Logger through its Logger
interface which matches Storage's writeToCoderOutputChannel method.
Since Storage now has Logger set (from extension.ts changes),
headers.ts automatically benefits from structured logging.

🤖 Generated with Claude Code

Co-Authored-By: Claude &lt;noreply@anthropic.com&gt;
diff --git a/TODO.md b/TODO.md
@@ -22,7 +22,8 @@
 1. **Replace writeToCoderOutputChannel calls** (43 instances across 10 files)
    - ✅ remote.ts (18) - Completed with Logger integration test
    - ✅ extension.ts (8) - Completed with Logger initialization and test
-   - Priority: headers.ts (4)
+   - ✅ headers.ts (4) - Completed via Logger interface compatibility
+   - Remaining: workspaceMonitor.ts (3), inbox.ts (3), error.ts (2), workspacesProvider.ts (1), commands.ts (1)
    - Use TDD approach: write test → implement → verify
 2. **Add structured logging to high-value areas**
    - API calls and responses
@@ -58,7 +59,7 @@
 | ------------------------ | ------ | ------- | ----------- |
 | Unit test coverage       | 80%+   | 74.38%  | 🔄 Progress |
 | Integration tests        | 60+    | 69      | ✅ Complete |
-| Logger adoption          | 100%   | 20%     | 🔄 Progress |
+| Logger adoption          | 100%   | 30%     | 🔄 Progress |
 | Files with <50% coverage | 0      | 3       | 🔄 Progress |
 
 ## Immediate Next Steps
diff --git a/src/headers.test.ts b/src/headers.test.ts
@@ -2,6 +2,7 @@ import * as os from "os";
 import { it, expect, describe, beforeEach, afterEach, vi } from "vitest";
 import { WorkspaceConfiguration } from "vscode";
 import { getHeaderArgs, getHeaderCommand, getHeaders } from "./headers";
+import { createMockOutputChannelWithLogger } from "./test-helpers";
 
 const logger = {
 	writeToCoderOutputChannel() {
@@ -189,3 +190,65 @@ describe("getHeaderArgs", () => {
 		expect(result[1]).toContain("hello world");
 	});
 });
+
+describe("Logger integration", () => {
+	it("should log errors through Logger when header command fails", async () => {
+		const { mockOutputChannel, logger: realLogger } =
+			createMockOutputChannelWithLogger();
+
+		// Use the backward compatibility method
+		const loggerWrapper = {
+			writeToCoderOutputChannel: (msg: string) =>
+				realLogger.writeToCoderOutputChannel(msg),
+		};
+
+		// Test with a failing command
+		await expect(
+			getHeaders("localhost", "exit 42", loggerWrapper),
+		).rejects.toThrow("Header command exited unexpectedly with code 42");
+
+		// Verify error was logged through Logger
+		const logs = realLogger.getLogs();
+		expect(logs).toHaveLength(3); // Main error + stdout + stderr
+
+		const logMessages = logs.map((log) => log.message);
+		expect(logMessages[0]).toBe(
+			"Header command exited unexpectedly with code 42",
+		);
+		expect(logMessages[1]).toContain("stdout:");
+		expect(logMessages[2]).toContain("stderr:");
+
+		// Verify output channel received formatted messages
+		expect(mockOutputChannel.appendLine).toHaveBeenCalledWith(
+			expect.stringMatching(
+				/\[.*\] \[INFO\] Header command exited unexpectedly with code 42/,
+			),
+		);
+	});
+
+	it("should work with Storage instance that has Logger set", async () => {
+		const { logger: realLogger } = createMockOutputChannelWithLogger();
+
+		// Simulate Storage with Logger
+		const mockStorage = {
+			writeToCoderOutputChannel: (msg: string) => {
+				realLogger.info(msg);
+			},
+		};
+
+		// Test with a failing command
+		await expect(
+			getHeaders("localhost", "command-not-found", mockStorage),
+		).rejects.toThrow(/Header command exited unexpectedly/);
+
+		// Verify error was logged
+		const logs = realLogger.getLogs();
+		expect(logs.length).toBeGreaterThan(0);
+
+		// At least the main error should be logged
+		const hasMainError = logs.some((log) =>
+			log.message.includes("Header command exited unexpectedly"),
+		);
+		expect(hasMainError).toBe(true);
+	});
+});
