From 8b704c2b2b51f4ac1958b5aa38c689d3c5272cd7 Mon Sep 17 00:00:00 2001 From: Sas Swart Date: Wed, 25 Jun 2025 13:49:01 +0000 Subject: [PATCH 1/5] fix: hide the preset parameter visibility switch when it has no effect --- .../CreateWorkspacePageView.tsx | 39 ++++++++++--------- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx index 27053ae4802e5..9de49c345159c 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx @@ -387,25 +387,28 @@ export const CreateWorkspacePageView: FC = ({ selectedOption={presetOptions[selectedPresetIndex]} /> -
- -
+ )} )} From fb04067ae8a6ef68e091547e6256e895fe3d0719 Mon Sep 17 00:00:00 2001 From: Sas Swart Date: Wed, 25 Jun 2025 13:57:51 +0000 Subject: [PATCH 2/5] apply the same fix to the experimental page --- .../CreateWorkspacePageViewExperimental.tsx | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx index 59277d5f07aa9..0b25e92b00e4c 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx @@ -594,16 +594,19 @@ export const CreateWorkspacePageViewExperimental: FC< - - - - + {/* Only show the preset parameter visibility toggle if preset parameters are actually being modified, otherwise it is ineffectual */} + {presetParameterNames.length > 0 && ( + + + + + )} )} From dc3c497ecf91f9632d6927333a18b35089dd2303 Mon Sep 17 00:00:00 2001 From: Sas Swart Date: Wed, 25 Jun 2025 14:04:04 +0000 Subject: [PATCH 3/5] fix default preset story --- .../CreateWorkspacePage/CreateWorkspacePageView.stories.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx index 2d38e1f3a7dc1..f085c74c57073 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx @@ -277,6 +277,8 @@ export const PresetsWithDefault: Story = { }, play: async ({ canvasElement }) => { const canvas = within(canvasElement); + // Wait for the switch to be available since preset parameters are populated asynchronously + await canvas.findByLabelText("Show preset parameters"); // Toggle off the show preset parameters switch await userEvent.click(canvas.getByLabelText("Show preset parameters")); }, From 6fdc046cee17bd1928acd9ec8edb094d69171592 Mon Sep 17 00:00:00 2001 From: Sas Swart Date: Wed, 25 Jun 2025 14:15:06 +0000 Subject: [PATCH 4/5] feat: remove the beta badge for presets --- .../CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx index 0b25e92b00e4c..8cb6c4acb6e49 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx @@ -562,7 +562,6 @@ export const CreateWorkspacePageViewExperimental: FC<
-
From ea01ac5f5cbfac56703cfabaea67d29d159bd56b Mon Sep 17 00:00:00 2001 From: Sas Swart Date: Thu, 26 Jun 2025 10:29:39 +0200 Subject: [PATCH 5/5] Update site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx Co-authored-by: Susana Ferreira --- site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx index 9de49c345159c..1b78922d31490 100644 --- a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx +++ b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx @@ -387,7 +387,7 @@ export const CreateWorkspacePageView: FC = ({ selectedOption={presetOptions[selectedPresetIndex]} /> - {/* Only show the preset parameter visibility toggle if preset parameters are actually being modified, otherwise it is ineffectual */} + {/* Only show the preset parameter visibility toggle if preset parameters are actually being modified, otherwise it has no effect. */} {presetParameterNames.length > 0 && (