fix(site): allow template admins to see template notification settings

DanielleMaywood · DanielleMaywood · commit e23db577b76b · 2025-07-30T09:04:20.000Z
Template admins have been unable to change their notification
preferences via the website as we have historically hidden the settings
for them. This PR ensures the frontend shows template events settings
when a user has the `createTemplates` permission.
diff --git a/site/src/pages/UserSettingsPage/NotificationsPage/NotificationsPage.stories.tsx b/site/src/pages/UserSettingsPage/NotificationsPage/NotificationsPage.stories.tsx
@@ -78,6 +78,12 @@ export const NonAdmin: Story = {
 	},
 };
 
+export const TemplateCreator: Story = {
+	parameters: {
+		permissions: { viewDeploymentConfig: false, createTemplates: true },
+	},
+};
+
 // Ensure the selected notification template is enabled before attempting to
 // disable it.
 const enabledPreference = MockNotificationPreferences.find(
diff --git a/site/src/pages/UserSettingsPage/NotificationsPage/NotificationsPage.tsx b/site/src/pages/UserSettingsPage/NotificationsPage/NotificationsPage.tsx
@@ -48,12 +48,19 @@ const NotificationsPage: FC = () => {
 				...systemNotificationTemplates(),
 				select: (data: NotificationTemplate[]) => {
 					const groups = selectTemplatesByGroup(data);
-					return permissions.viewDeploymentConfig
-						? groups
-						: {
-								// Members only have access to the "Workspace Notifications" group
-								"Workspace Events": groups["Workspace Events"],
-							};
+
+					let displayedGroups: Record<string, NotificationTemplate[]> = {
+						// Members only have access to the "Workspace Notifications" group.
+						"Workspace Events": groups["Workspace Events"],
+					};
+
+					if (permissions.viewDeploymentConfig) {
+						displayedGroups = groups;
+					} else if (permissions.createTemplates) {
+						displayedGroups["Template Events"] = groups["Template Events"];
+					}
+
+					return displayedGroups;
 				},
 			},
 			notificationDispatchMethods(),
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -4402,6 +4402,32 @@ export const MockNotificationTemplates: TypesGen.NotificationTemplate[] = [
 		kind: "system",
 		enabled_by_default: true,
 	},
+	{
+		id: "template-event-1",
+		name: "Template Version Created",
+		title_template: 'Template version "{{.Labels.version_name}}" created',
+		body_template:
+			'Hi {{.UserName}}\nA new version of template "{{.Labels.template_name}}" has been created.',
+		actions:
+			'[{"url": "{{ base_url }}/templates/{{.Labels.template_name}}", "label": "View template"}]',
+		group: "Template Events",
+		method: "smtp",
+		kind: "system",
+		enabled_by_default: true,
+	},
+	{
+		id: "template-event-2",
+		name: "Template Updated",
+		title_template: 'Template "{{.Labels.template_name}}" updated',
+		body_template:
+			'Hi {{.UserName}}\nTemplate "{{.Labels.template_name}}" has been updated.',
+		actions:
+			'[{"url": "{{ base_url }}/templates/{{.Labels.template_name}}", "label": "View template"}]',
+		group: "Template Events",
+		method: "webhook",
+		kind: "system",
+		enabled_by_default: true,
+	},
 ];
 
 export const MockNotificationMethodsResponse: TypesGen.NotificationMethodsResponse =
