s/DisableDatabaseStorage/DisableDatabaseInserts

code-asher · code-asher · commit be20e54e4f29 · 2025-12-10T18:34:04.000-09:00
diff --git a/coderd/agentapi/stats_test.go b/coderd/agentapi/stats_test.go
@@ -617,7 +617,7 @@ func TestUpdateStats(t *testing.T) {
 					}, labels)
 					assert.Equal(t, req.Stats.Metrics, metrics)
 				},
-				DisableDatabaseStorage: true,
+				DisableDatabaseInserts: true,
 			}),
 			AgentStatsRefreshInterval: 10 * time.Second,
 			TimeNowFn: func() time.Time {
diff --git a/coderd/coderd.go b/coderd/coderd.go
@@ -776,7 +776,7 @@ func New(options *Options) *API {
 		UsageTracker:           options.WorkspaceUsageTracker,
 		UpdateAgentMetricsFn:   options.UpdateAgentMetrics,
 		AppStatBatchSize:       workspaceapps.DefaultStatsDBReporterBatchSize,
-		DisableDatabaseStorage: !options.DeploymentValues.TemplateInsights.Enable.Value(),
+		DisableDatabaseInserts: !options.DeploymentValues.TemplateInsights.Enable.Value(),
 	})
 	workspaceAppsLogger := options.Logger.Named("workspaceapps")
 	if options.WorkspaceAppsStatsCollectorOptions.Logger == nil {
diff --git a/coderd/insights_test.go b/coderd/insights_test.go
@@ -754,7 +754,7 @@ func TestTemplateInsights_Golden(t *testing.T) {
 		reporter := workspacestats.NewReporter(workspacestats.ReporterOptions{
 			Database:               db,
 			AppStatBatchSize:       workspaceapps.DefaultStatsDBReporterBatchSize,
-			DisableDatabaseStorage: disableStorage,
+			DisableDatabaseInserts: disableStorage,
 		})
 		err = reporter.ReportAppStats(dbauthz.AsSystemRestricted(ctx), stats)
 		require.NoError(t, err, "want no error inserting app stats")
@@ -1665,7 +1665,7 @@ func TestUserActivityInsights_Golden(t *testing.T) {
 		reporter := workspacestats.NewReporter(workspacestats.ReporterOptions{
 			Database:               db,
 			AppStatBatchSize:       workspaceapps.DefaultStatsDBReporterBatchSize,
-			DisableDatabaseStorage: disableStorage,
+			DisableDatabaseInserts: disableStorage,
 		})
 		err = reporter.ReportAppStats(dbauthz.AsSystemRestricted(ctx), stats)
 		require.NoError(t, err, "want no error inserting app stats")
diff --git a/coderd/workspacestats/reporter.go b/coderd/workspacestats/reporter.go
@@ -48,9 +48,9 @@ type ReporterOptions struct {
 	UsageTracker          *UsageTracker
 	UpdateAgentMetricsFn  func(ctx context.Context, labels prometheusmetrics.AgentMetricLabels, metrics []*agentproto.Stats_Metric)
 
-	// DisableDatabaseStorage prevents storing stats in the database.  The
+	// DisableDatabaseInserts prevents inserting stats in the database.  The
 	// reporter will still call UpdateAgentMetricsFn and bump workspace activity.
-	DisableDatabaseStorage bool
+	DisableDatabaseInserts bool
 
 	AppStatBatchSize int
 }
@@ -114,7 +114,7 @@ func (r *Reporter) ReportAppStats(ctx context.Context, stats []workspaceapps.Sta
 			return nil
 		}
 
-		if !r.opts.DisableDatabaseStorage {
+		if !r.opts.DisableDatabaseInserts {
 			if err := tx.InsertWorkspaceAppStats(ctx, batch); err != nil {
 				return err
 			}
@@ -140,7 +140,7 @@ func (r *Reporter) ReportAppStats(ctx context.Context, stats []workspaceapps.Sta
 // nolint:revive // usage is a control flag while we have the experiment
 func (r *Reporter) ReportAgentStats(ctx context.Context, now time.Time, workspace database.WorkspaceIdentity, workspaceAgent database.WorkspaceAgent, stats *agentproto.Stats, usage bool) error {
 	// update agent stats
-	if !r.opts.DisableDatabaseStorage {
+	if !r.opts.DisableDatabaseInserts {
 		r.opts.StatsBatcher.Add(now, workspaceAgent.ID, workspace.TemplateID, workspace.OwnerID, workspace.ID, stats, usage)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,9 @@ type ReporterOptions struct {`
`48`	`48`	`UsageTracker *UsageTracker`
`49`	`49`	`UpdateAgentMetricsFn func(ctx context.Context, labels prometheusmetrics.AgentMetricLabels, metrics []*agentproto.Stats_Metric)`
`50`	`50`
`51`		`- // DisableDatabaseStorage prevents storing stats in the database. The`
	`51`	`+ // DisableDatabaseInserts prevents inserting stats in the database. The`
`52`	`52`	`// reporter will still call UpdateAgentMetricsFn and bump workspace activity.`
`53`		`- DisableDatabaseStorage bool`
	`53`	`+ DisableDatabaseInserts bool`
`54`	`54`
`55`	`55`	`AppStatBatchSize int`
`56`	`56`	`}`
`@@ -114,7 +114,7 @@ func (r *Reporter) ReportAppStats(ctx context.Context, stats []workspaceapps.Sta`
`114`	`114`	`return nil`
`115`	`115`	`}`
`116`	`116`
`117`		`- if !r.opts.DisableDatabaseStorage {`
	`117`	`+ if !r.opts.DisableDatabaseInserts {`
`118`	`118`	`if err := tx.InsertWorkspaceAppStats(ctx, batch); err != nil {`
`119`	`119`	`return err`
`120`	`120`	`}`
`@@ -140,7 +140,7 @@ func (r *Reporter) ReportAppStats(ctx context.Context, stats []workspaceapps.Sta`
`140`	`140`	`// nolint:revive // usage is a control flag while we have the experiment`
`141`	`141`	`func (r Reporter) ReportAgentStats(ctx context.Context, now time.Time, workspace database.WorkspaceIdentity, workspaceAgent database.WorkspaceAgent, stats agentproto.Stats, usage bool) error {`
`142`	`142`	`// update agent stats`
`143`		`- if !r.opts.DisableDatabaseStorage {`
	`143`	`+ if !r.opts.DisableDatabaseInserts {`
`144`	`144`	`r.opts.StatsBatcher.Add(now, workspaceAgent.ID, workspace.TemplateID, workspace.OwnerID, workspace.ID, stats, usage)`
`145`	`145`	`}`
`146`	`146`