fix: remove a sensitive field from an agent log line (#20968) (#21063)

blinkagent[bot] · SasSwart · web-flow · commit ba71b321bcea · 2025-12-02T11:33:50.000-06:00
This PR removes a log field that could expose sensitive information in agent logs for workspaces that pass such information to the agent via its manifest. (cherry picked from commit 1d726c8) Co-authored-by: Sas Swart <sas.swart.cdk@gmail.com>
diff --git a/agent/agent.go b/agent/agent.go
@@ -1127,7 +1127,7 @@ func (a *agent) handleManifest(manifestOK *checkpoint) func(ctx context.Context,
 		if err != nil {
 			return xerrors.Errorf("fetch metadata: %w", err)
 		}
-		a.logger.Info(ctx, "fetched manifest", slog.F("manifest", mp))
+		a.logger.Info(ctx, "fetched manifest")
 		manifest, err := agentsdk.ManifestFromProto(mp)
 		if err != nil {
 			a.logger.Critical(ctx, "failed to convert manifest", slog.F("manifest", mp), slog.Error(err))

Original file line number	Diff line number	Diff line change
`@@ -1127,7 +1127,7 @@ func (a agent) handleManifest(manifestOK checkpoint) func(ctx context.Context,`
`1127`	`1127`	`if err != nil {`
`1128`	`1128`	`return xerrors.Errorf("fetch metadata: %w", err)`
`1129`	`1129`	`}`
`1130`		`- a.logger.Info(ctx, "fetched manifest", slog.F("manifest", mp))`
	`1130`	`+ a.logger.Info(ctx, "fetched manifest")`
`1131`	`1131`	`manifest, err := agentsdk.ManifestFromProto(mp)`
`1132`	`1132`	`if err != nil {`
`1133`	`1133`	`a.logger.Critical(ctx, "failed to convert manifest", slog.F("manifest", mp), slog.Error(err))`