fix(e2e): disable dynamic parameters for updateWorkspace tests

blink-so[bot] · blink-so[bot] · commit 95f53fd02c2c · 2025-07-28T21:13:23.000Z
The updateWorkspace tests were written for the classic parameter flow.
With dynamic parameters now being the default, these tests need to
explicitly disable dynamic parameters via the template settings page
to continue working as expected.

This fix:
1. Adds a disableDynamicParameters helper function
2. Modifies all updateWorkspace tests to disable dynamic parameters
   after template creation
3. Ensures tests use the classic parameter flow they were designed for

Fixes the failing e2e test 'update workspace with ephemeral parameter enabled'.
diff --git a/site/e2e/helpers.ts b/site/e2e/helpers.ts
@@ -1203,3 +1203,36 @@ export async function addUserToOrganization(
 	}
 	await page.mouse.click(10, 10); // close the popover by clicking outside of it
 }
+
+/**
+ * disableDynamicParameters navigates to the template settings page and disables
+ * dynamic parameters by unchecking the "Enable dynamic parameters" checkbox.
+ */
+export const disableDynamicParameters = async (
+	page: Page,
+	templateName: string,
+	orgName = defaultOrganizationName,
+) => {
+	await page.goto(`/templates/${orgName}/${templateName}/settings`, {
+		waitUntil: "domcontentloaded",
+	});
+
+	// Find and uncheck the "Enable dynamic parameters" checkbox
+	const dynamicParamsCheckbox = page.getByRole("checkbox", {
+		name: /Enable dynamic parameters for workspace creation/,
+	});
+	
+	// If the checkbox is checked, uncheck it
+	if (await dynamicParamsCheckbox.isChecked()) {
+		await dynamicParamsCheckbox.click();
+	}
+
+	// Save the changes
+	await page.getByRole("button", { name: /save/i }).click();
+
+	// Wait for the success message or page to update
+	await page.waitForSelector("text=Template updated successfully", {
+		state: "visible",
+		timeout: 10000,
+	});
+};
diff --git a/site/e2e/tests/workspaces/updateWorkspace.spec.ts b/site/e2e/tests/workspaces/updateWorkspace.spec.ts
@@ -3,6 +3,7 @@ import { users } from "../../constants";
 import {
 	createTemplate,
 	createWorkspace,
+	disableDynamicParameters,
 	echoResponsesWithParameters,
 	updateTemplate,
 	updateWorkspace,
@@ -34,6 +35,9 @@ test("update workspace, new optional, immutable parameter added", async ({
 		echoResponsesWithParameters(richParameters),
 	);
 
+	// Disable dynamic parameters to use classic parameter flow for this test
+	await disableDynamicParameters(page, template);
+
 	await login(page, users.member);
 	const workspaceName = await createWorkspace(page, template);
 
@@ -77,6 +81,9 @@ test("update workspace, new required, mutable parameter added", async ({
 		echoResponsesWithParameters(richParameters),
 	);
 
+	// Disable dynamic parameters to use classic parameter flow for this test
+	await disableDynamicParameters(page, template);
+
 	await login(page, users.member);
 	const workspaceName = await createWorkspace(page, template);
 
@@ -122,6 +129,9 @@ test("update workspace with ephemeral parameter enabled", async ({ page }) => {
 		echoResponsesWithParameters(richParameters),
 	);
 
+	// Disable dynamic parameters to use classic parameter flow for this test
+	await disableDynamicParameters(page, template);
+
 	await login(page, users.member);
 	const workspaceName = await createWorkspace(page, template);
 
