Skip to content

Commit 675b528

Browse files
committed
PR feedback
1 parent a753ff4 commit 675b528

File tree

4 files changed

+25
-28
lines changed

4 files changed

+25
-28
lines changed

codersdk/deployment.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ type ExternalAuthConfig struct {
768768
// DisplayIcon is a URL to an icon to display in the UI.
769769
DisplayIcon string `json:"display_icon" yaml:"display_icon"`
770770
// CodeChallengeMethodsSupported lists the PKCE code challenge methods
771-
// The only one supported by Coder is "S256"
771+
// The only one supported by Coder is "S256".
772772
CodeChallengeMethodsSupported []string `json:"code_challenge_methods_supported" yaml:"code_challenge_methods_supported"`
773773
}
774774

@@ -1674,8 +1674,7 @@ func (c *DeploymentValues) Options() serpent.OptionSet {
16741674
Env: "CODER_BLOCK_DIRECT",
16751675
Value: &c.DERP.Config.BlockDirect,
16761676
Group: &deploymentGroupNetworkingDERP,
1677-
YAML: "blockDirect", Annotations: serpent.Annotations{}.
1678-
Mark(annotationExternalProxies, "true"),
1677+
YAML: "blockDirect", Annotations: serpent.Annotations{}.Mark(annotationExternalProxies, "true"),
16791678
},
16801679
{
16811680
Name: "DERP Force WebSockets",

docs/admin/external-auth/index.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,6 @@ You must add the SSH key to your Git provider.
133133
- [GitHub](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account#adding-a-new-ssh-key-to-your-account)
134134
- [GitLab](https://docs.gitlab.com/user/ssh/#add-an-ssh-key-to-your-gitlab-account)
135135

136-
##
137-
138136
## PKCE Support
139137

140138
[PKCE (Proof Key for Code Exchange)](https://datatracker.ietf.org/doc/html/rfc7636) is an OAuth 2.0

docs/reference/api/schemas.md

Lines changed: 22 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

site/src/api/typesGenerated.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)