chore: remove global retention fallback for audit logs

mafredri · mafredri · commit 5a4735284d05 · 2025-12-02T12:55:09.000Z
Audit logs retention is now explicit - it's enabled when
--audit-logs-retention is set to a non-zero duration, and
disabled when set to 0. No fallback to global retention.
diff --git a/coderd/database/dbpurge/dbpurge.go b/coderd/database/dbpurge/dbpurge.go
@@ -130,9 +130,6 @@ func New(ctx context.Context, logger slog.Logger, db database.Store, vals *coder
 
 			var purgedAuditLogs int64
 			auditLogsRetention := vals.Retention.AuditLogs.Value()
-			if auditLogsRetention == 0 {
-				auditLogsRetention = vals.Retention.Global.Value()
-			}
 			if auditLogsRetention > 0 {
 				deleteAuditLogsBefore := start.Add(-auditLogsRetention)
 				purgedAuditLogs, err = tx.DeleteOldAuditLogs(ctx, database.DeleteOldAuditLogsParams{
diff --git a/coderd/database/dbpurge/dbpurge_test.go b/coderd/database/dbpurge/dbpurge_test.go
@@ -1087,17 +1087,6 @@ func TestDeleteOldAuditLogs(t *testing.T) {
 			expectOldDeleted:      false,
 			expectedLogsRemaining: 1, // old log is kept
 		},
-		{
-			name: "GlobalRetentionFallback",
-			retentionConfig: codersdk.RetentionConfig{
-				Global:    serpent.Duration(retentionPeriod),
-				AuditLogs: serpent.Duration(0), // Not set, should fall back to global
-			},
-			oldLogTime:            afterThreshold,
-			recentLogTime:         &beforeThreshold,
-			expectOldDeleted:      true,
-			expectedLogsRemaining: 1, // only recent log remains
-		},
 	}
 
 	for _, tc := range testCases {
