Skip to content

Commit 4eb35ac

Browse files
mafredrimafredri
committed
feat(coderd/database/dbpurge): add retention for workspace agent logs
Replace hardcoded 7-day retention for workspace agent logs with configurable retention from deployment settings. Falls back to global retention when not set, and skips deletion entirely when effective retention is 0. Depends on #21038 Updates #20743
1 parent 7e8a005 commit 4eb35ac

File tree

10 files changed

+2273
-2012
lines changed

10 files changed

+2273
-2012
lines changed

‎cli/testdata/coder_server_--help.golden‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -725,6 +725,11 @@ that data type.
725725
disable (data is kept indefinitely unless individual settings are
726726
configured).
727727

728+
--workspace-agent-logs-retention duration, $CODER_WORKSPACE_AGENT_LOGS_RETENTION (default: 7d)
729+
How long workspace agent logs are retained. Logs from non-latest
730+
workspace builds are deleted after this period to free up storage
731+
space. Set to 0 to disable automatic deletion of workspace agent logs.
732+
728733
TELEMETRY OPTIONS:
729734
Telemetry is critical to our ability to improve Coder. We strip all personal
730735
information before sending data to our servers. Please only disable telemetry

‎cli/testdata/server-config.yaml.golden‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -780,3 +780,8 @@ retention:
780780
# an expired key. Set to 0 to disable automatic deletion of expired keys.
781781
# (default: 7d, type: duration)
782782
api_keys: 168h0m0s
783+
# How long workspace agent logs are retained. Logs from non-latest workspace
784+
# builds are deleted after this period to free up storage space. Set to 0 to
785+
# disable automatic deletion of workspace agent logs.
786+
# (default: 7d, type: duration)
787+
workspace_agent_logs: 168h0m0s

‎coderd/database/dbpurge/dbpurge.go‎

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@ import (
1818
)
1919

2020
const (
21-
delay = 10 * time.Minute
22-
maxAgentLogAge = 7 * 24 * time.Hour
21+
delay = 10 * time.Minute
2322
// Connection events are now inserted into the `connection_logs` table.
2423
// We'll slowly remove old connection events from the `audit_logs` table,
2524
// but we won't touch the `connection_logs` table.
@@ -67,9 +66,15 @@ func New(ctx context.Context, logger slog.Logger, db database.Store, vals *coder
6766
return nil
6867
}
6968

70-
deleteOldWorkspaceAgentLogsBefore := start.Add(-maxAgentLogAge)
71-
if err := tx.DeleteOldWorkspaceAgentLogs(ctx, deleteOldWorkspaceAgentLogsBefore); err != nil {
72-
return xerrors.Errorf("failed to delete old workspace agent logs: %w", err)
69+
workspaceAgentLogsRetention := vals.Retention.WorkspaceAgentLogs.Value()
70+
if workspaceAgentLogsRetention == 0 {
71+
workspaceAgentLogsRetention = vals.Retention.Global.Value()
72+
}
73+
if workspaceAgentLogsRetention > 0 {
74+
deleteOldWorkspaceAgentLogsBefore := start.Add(-workspaceAgentLogsRetention)
75+
if err := tx.DeleteOldWorkspaceAgentLogs(ctx, deleteOldWorkspaceAgentLogsBefore); err != nil {
76+
return xerrors.Errorf("failed to delete old workspace agent logs: %w", err)
77+
}
7378
}
7479
if err := tx.DeleteOldWorkspaceAgentStats(ctx); err != nil {
7580
return xerrors.Errorf("failed to delete old workspace agent stats: %w", err)

‎coderd/database/dbpurge/dbpurge_test.go‎

Lines changed: 141 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,147 @@ func mustCreateAgentLogs(ctx context.Context, t *testing.T, db database.Store, a
392392
require.NotEmpty(t, agentLogs, "agent logs must be present")
393393
}
394394

395+
func TestDeleteOldWorkspaceAgentLogsRetention(t *testing.T) {
396+
t.Parallel()
397+
398+
t.Run("CustomRetention", func(t *testing.T) {
399+
t.Parallel()
400+
401+
ctx := testutil.Context(t, testutil.WaitShort)
402+
clk := quartz.NewMock(t)
403+
now := dbtime.Now()
404+
retentionPeriod := 30 * 24 * time.Hour
405+
threshold := now.Add(-retentionPeriod)
406+
beforeThreshold := threshold.Add(-24 * time.Hour) // 31 days ago
407+
afterThreshold := threshold.Add(24 * time.Hour) // 29 days ago
408+
clk.Set(now).MustWait(ctx)
409+
410+
db, _ := dbtestutil.NewDB(t, dbtestutil.WithDumpOnFailure())
411+
org := dbgen.Organization(t, db, database.Organization{})
412+
user := dbgen.User(t, db, database.User{})
413+
_ = dbgen.OrganizationMember(t, db, database.OrganizationMember{UserID: user.ID, OrganizationID: org.ID})
414+
tv := dbgen.TemplateVersion(t, db, database.TemplateVersion{OrganizationID: org.ID, CreatedBy: user.ID})
415+
tmpl := dbgen.Template(t, db, database.Template{OrganizationID: org.ID, ActiveVersionID: tv.ID, CreatedBy: user.ID})
416+
417+
logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true})
418+
419+
// Workspace with two builds, both before the 30-day threshold.
420+
ws := dbgen.Workspace(t, db, database.WorkspaceTable{Name: "test-ws", OwnerID: user.ID, OrganizationID: org.ID, TemplateID: tmpl.ID})
421+
wb1 := mustCreateWorkspaceBuild(t, db, org, tv, ws.ID, beforeThreshold, 1)
422+
wb2 := mustCreateWorkspaceBuild(t, db, org, tv, ws.ID, beforeThreshold, 2)
423+
agent1 := mustCreateAgent(t, db, wb1)
424+
agent2 := mustCreateAgent(t, db, wb2)
425+
mustCreateAgentLogs(ctx, t, db, agent1, &beforeThreshold, "agent 1 logs should be deleted")
426+
mustCreateAgentLogs(ctx, t, db, agent2, &beforeThreshold, "agent 2 logs should be retained")
427+
428+
// Workspace with build after the 30-day threshold.
429+
wsRecent := dbgen.Workspace(t, db, database.WorkspaceTable{Name: "recent-ws", OwnerID: user.ID, OrganizationID: org.ID, TemplateID: tmpl.ID})
430+
wbRecent := mustCreateWorkspaceBuild(t, db, org, tv, wsRecent.ID, afterThreshold, 1)
431+
agentRecent := mustCreateAgent(t, db, wbRecent)
432+
mustCreateAgentLogs(ctx, t, db, agentRecent, &afterThreshold, "recent agent logs should be retained")
433+
434+
done := awaitDoTick(ctx, t, clk)
435+
closer := dbpurge.New(ctx, logger, db, &codersdk.DeploymentValues{
436+
Retention: codersdk.RetentionConfig{
437+
WorkspaceAgentLogs: serpent.Duration(retentionPeriod),
438+
},
439+
}, clk)
440+
defer closer.Close()
441+
testutil.TryReceive(ctx, t, done)
442+
443+
// Agent 1 logs should be deleted (non-latest build, older than 30 days).
444+
assertNoWorkspaceAgentLogs(ctx, t, db, agent1.ID)
445+
// Agent 2 logs should be retained (latest build).
446+
assertWorkspaceAgentLogs(ctx, t, db, agent2.ID, "agent 2 logs should be retained")
447+
// Recent agent logs should be retained (within 30-day threshold).
448+
assertWorkspaceAgentLogs(ctx, t, db, agentRecent.ID, "recent agent logs should be retained")
449+
})
450+
451+
t.Run("RetentionDisabled", func(t *testing.T) {
452+
t.Parallel()
453+
454+
ctx := testutil.Context(t, testutil.WaitShort)
455+
clk := quartz.NewMock(t)
456+
now := dbtime.Now()
457+
veryOld := now.Add(-60 * 24 * time.Hour)
458+
clk.Set(now).MustWait(ctx)
459+
460+
db, _ := dbtestutil.NewDB(t, dbtestutil.WithDumpOnFailure())
461+
org := dbgen.Organization(t, db, database.Organization{})
462+
user := dbgen.User(t, db, database.User{})
463+
_ = dbgen.OrganizationMember(t, db, database.OrganizationMember{UserID: user.ID, OrganizationID: org.ID})
464+
tv := dbgen.TemplateVersion(t, db, database.TemplateVersion{OrganizationID: org.ID, CreatedBy: user.ID})
465+
tmpl := dbgen.Template(t, db, database.Template{OrganizationID: org.ID, ActiveVersionID: tv.ID, CreatedBy: user.ID})
466+
467+
logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true})
468+
469+
ws := dbgen.Workspace(t, db, database.WorkspaceTable{Name: "test-ws", OwnerID: user.ID, OrganizationID: org.ID, TemplateID: tmpl.ID})
470+
wb1 := mustCreateWorkspaceBuild(t, db, org, tv, ws.ID, veryOld, 1)
471+
wb2 := mustCreateWorkspaceBuild(t, db, org, tv, ws.ID, veryOld, 2)
472+
agent1 := mustCreateAgent(t, db, wb1)
473+
agent2 := mustCreateAgent(t, db, wb2)
474+
mustCreateAgentLogs(ctx, t, db, agent1, &veryOld, "agent 1 logs")
475+
mustCreateAgentLogs(ctx, t, db, agent2, &veryOld, "agent 2 logs")
476+
477+
done := awaitDoTick(ctx, t, clk)
478+
closer := dbpurge.New(ctx, logger, db, &codersdk.DeploymentValues{
479+
Retention: codersdk.RetentionConfig{
480+
WorkspaceAgentLogs: serpent.Duration(0),
481+
Global: serpent.Duration(0),
482+
},
483+
}, clk)
484+
defer closer.Close()
485+
testutil.TryReceive(ctx, t, done)
486+
487+
// Both agent logs should be retained when retention is disabled.
488+
assertWorkspaceAgentLogs(ctx, t, db, agent1.ID, "agent 1 logs")
489+
assertWorkspaceAgentLogs(ctx, t, db, agent2.ID, "agent 2 logs")
490+
})
491+
492+
t.Run("GlobalRetentionFallback", func(t *testing.T) {
493+
t.Parallel()
494+
495+
ctx := testutil.Context(t, testutil.WaitShort)
496+
clk := quartz.NewMock(t)
497+
now := dbtime.Now()
498+
retentionPeriod := 14 * 24 * time.Hour
499+
threshold := now.Add(-retentionPeriod)
500+
beforeThreshold := threshold.Add(-24 * time.Hour)
501+
afterThreshold := threshold.Add(24 * time.Hour)
502+
clk.Set(now).MustWait(ctx)
503+
504+
db, _ := dbtestutil.NewDB(t, dbtestutil.WithDumpOnFailure())
505+
org := dbgen.Organization(t, db, database.Organization{})
506+
user := dbgen.User(t, db, database.User{})
507+
_ = dbgen.OrganizationMember(t, db, database.OrganizationMember{UserID: user.ID, OrganizationID: org.ID})
508+
tv := dbgen.TemplateVersion(t, db, database.TemplateVersion{OrganizationID: org.ID, CreatedBy: user.ID})
509+
tmpl := dbgen.Template(t, db, database.Template{OrganizationID: org.ID, ActiveVersionID: tv.ID, CreatedBy: user.ID})
510+
511+
logger := slogtest.Make(t, &slogtest.Options{IgnoreErrors: true})
512+
513+
ws := dbgen.Workspace(t, db, database.WorkspaceTable{Name: "test-ws", OwnerID: user.ID, OrganizationID: org.ID, TemplateID: tmpl.ID})
514+
wb1 := mustCreateWorkspaceBuild(t, db, org, tv, ws.ID, beforeThreshold, 1)
515+
wb2 := mustCreateWorkspaceBuild(t, db, org, tv, ws.ID, afterThreshold, 2)
516+
agent1 := mustCreateAgent(t, db, wb1)
517+
agent2 := mustCreateAgent(t, db, wb2)
518+
mustCreateAgentLogs(ctx, t, db, agent1, &beforeThreshold, "agent 1 logs")
519+
mustCreateAgentLogs(ctx, t, db, agent2, &afterThreshold, "agent 2 logs")
520+
521+
done := awaitDoTick(ctx, t, clk)
522+
closer := dbpurge.New(ctx, logger, db, &codersdk.DeploymentValues{
523+
Retention: codersdk.RetentionConfig{
524+
WorkspaceAgentLogs: serpent.Duration(0),
525+
Global: serpent.Duration(retentionPeriod),
526+
},
527+
}, clk)
528+
defer closer.Close()
529+
testutil.TryReceive(ctx, t, done)
530+
531+
assertNoWorkspaceAgentLogs(ctx, t, db, agent1.ID)
532+
assertWorkspaceAgentLogs(ctx, t, db, agent2.ID, "agent 2 logs")
533+
})
534+
}
535+
395536
//nolint:paralleltest // It uses LockIDDBPurge.
396537
func TestDeleteOldProvisionerDaemons(t *testing.T) {
397538
// TODO: must refactor DeleteOldProvisionerDaemons to allow passing in cutoff

‎codersdk/deployment.go‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -834,6 +834,9 @@ type RetentionConfig struct {
834834
// Keys are only deleted if they have been expired for at least this duration.
835835
// Defaults to 7 days to preserve existing behavior.
836836
APIKeys serpent.Duration `json:"api_keys" typescript:",notnull"`
837+
// WorkspaceAgentLogs controls how long workspace agent logs are retained.
838+
// Defaults to 7 days to preserve existing behavior.
839+
WorkspaceAgentLogs serpent.Duration `json:"workspace_agent_logs" typescript:",notnull"`
837840
}
838841

839842
type NotificationsConfig struct {
@@ -3436,6 +3439,17 @@ Write out the current server config as YAML to stdout.`,
34363439
YAML: "api_keys",
34373440
Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"),
34383441
},
3442+
{
3443+
Name: "Workspace Agent Logs Retention",
3444+
Description: "How long workspace agent logs are retained. Logs from non-latest workspace builds are deleted after this period to free up storage space. Set to 0 to disable automatic deletion of workspace agent logs.",
3445+
Flag: "workspace-agent-logs-retention",
3446+
Env: "CODER_WORKSPACE_AGENT_LOGS_RETENTION",
3447+
Value: &c.Retention.WorkspaceAgentLogs,
3448+
Default: "7d",
3449+
Group: &deploymentGroupRetention,
3450+
YAML: "workspace_agent_logs",
3451+
Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"),
3452+
},
34393453
{
34403454
Name: "Enable Authorization Recordings",
34413455
Description: "All api requests will have a header including all authorization calls made during the request. " +

‎docs/admin/setup/data-retention.md‎

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Data Retention
22

33
Coder supports configurable retention policies that automatically purge old
4-
Audit Logs, Connection Logs, and API keys. These policies help manage database
5-
growth by removing records older than a specified duration.
4+
Audit Logs, Connection Logs, Workspace Agent Logs, and API keys. These policies
5+
help manage database growth by removing records older than a specified duration.
66

77
## Overview
88

@@ -25,12 +25,13 @@ a YAML configuration file.
2525

2626
### Settings
2727

28-
| Setting | CLI Flag | Environment Variable | Default | Description |
29-
|-----------------|-------------------------------|-----------------------------------|------------------|--------------------------------------------------------------------------|
30-
| Global | `--global-retention` | `CODER_GLOBAL_RETENTION` | `0` (disabled) | Default retention for all data types. Individual settings override this. |
31-
| Audit Logs | `--audit-logs-retention` | `CODER_AUDIT_LOGS_RETENTION` | `0` (use global) | How long to retain Audit Log entries. |
32-
| Connection Logs | `--connection-logs-retention` | `CODER_CONNECTION_LOGS_RETENTION` | `0` (use global) | How long to retain Connection Log entries. |
33-
| API Keys | `--api-keys-retention` | `CODER_API_KEYS_RETENTION` | `7d` | How long to retain expired API keys. |
28+
| Setting | CLI Flag | Environment Variable | Default | Description |
29+
|----------------------|------------------------------------|----------------------------------------|------------------|--------------------------------------------------------------------------|
30+
| Global | `--global-retention` | `CODER_GLOBAL_RETENTION` | `0` (disabled) | Default retention for all data types. Individual settings override this. |
31+
| Audit Logs | `--audit-logs-retention` | `CODER_AUDIT_LOGS_RETENTION` | `0` (use global) | How long to retain Audit Log entries. |
32+
| Connection Logs | `--connection-logs-retention` | `CODER_CONNECTION_LOGS_RETENTION` | `0` (use global) | How long to retain Connection Log entries. |
33+
| API Keys | `--api-keys-retention` | `CODER_API_KEYS_RETENTION` | `7d` | How long to retain expired API keys. |
34+
| Workspace Agent Logs | `--workspace-agent-logs-retention` | `CODER_WORKSPACE_AGENT_LOGS_RETENTION` | `7d` | How long to retain workspace agent logs. |
3435

3536
### Duration Format
3637

@@ -68,6 +69,7 @@ retention:
6869
audit_logs: 365d
6970
connection_logs: 0s
7071
api_keys: 7d
72+
workspace_agent_logs: 7d
7173
```
7274
7375
## How Retention Works
@@ -103,6 +105,16 @@ ago. Active keys are never deleted by the retention policy.
103105
Keeping expired keys for a short period allows Coder to return a more helpful
104106
error message when users attempt to use an expired key.
105107

108+
### Workspace Agent Logs Behavior
109+
110+
Workspace agent logs are retained based on the retention period, but **logs from
111+
the latest build of each workspace are always retained** regardless of age. This
112+
ensures you can always debug issues with active workspaces.
113+
114+
Only logs from non-latest workspace builds that are older than the retention
115+
period are deleted. Setting `--workspace-agent-logs-retention=7d` keeps all logs
116+
from the latest build plus logs from previous builds for up to 7 days.
117+
106118
## Best Practices
107119

108120
### Recommended Starting Configuration
@@ -115,6 +127,7 @@ retention:
115127
audit_logs: 365d
116128
connection_logs: 0s # Use global
117129
api_keys: 7d
130+
workspace_agent_logs: 7d
118131
```
119132

120133
### Compliance Considerations
@@ -160,6 +173,7 @@ retention:
160173
audit_logs: 0s
161174
connection_logs: 0s
162175
api_keys: 0s
176+
workspace_agent_logs: 0s
163177
```
164178

165179
There is no way to disable retention for a specific data type while global

0 commit comments

Comments
 (0)