fix: update state sync logic

Parkreiner · Parkreiner · commit 42cb73b7de2c · 2025-08-04T02:50:11.000Z
diff --git a/site/src/modules/resources/useAgentLogs.test.ts b/site/src/modules/resources/useAgentLogs.test.ts
@@ -180,17 +180,22 @@ describe("useAgentLogs", () => {
 		act(() => publisherResult.current?.publishMessage(initialEvent));
 		await waitFor(() => expect(hookResult.current).toEqual(initialLogs));
 
-		// Disable the hook
-		rerender({ agentId: MockWorkspaceAgent.id, enabled: false });
-		await waitFor(() => expect(hookResult.current).toHaveLength(0));
-
-		// Re-enable the hook and send new logs
-		rerender({ agentId: MockWorkspaceAgent.id, enabled: true });
-		const newLogs = generateMockLogs(3, new Date("october 3, 2005"));
-		const newEvent = new MessageEvent<string>("message", {
-			data: JSON.stringify(newLogs),
-		});
-		act(() => publisherResult.current?.publishMessage(newEvent));
-		await waitFor(() => expect(hookResult.current).toEqual(newLogs));
+		// Need to do the following steps multiple times to make sure that we
+		// don't break anything after the first disable
+		const mockDates: readonly string[] = ["october 3, 2005", "august 1, 2025"];
+		for (const md of mockDates) {
+			// Disable the hook to clear current logs
+			rerender({ agentId: MockWorkspaceAgent.id, enabled: false });
+			await waitFor(() => expect(hookResult.current).toHaveLength(0));
+
+			// Re-enable the hook and send new logs
+			rerender({ agentId: MockWorkspaceAgent.id, enabled: true });
+			const newLogs = generateMockLogs(3, new Date(md));
+			const newEvent = new MessageEvent<string>("message", {
+				data: JSON.stringify(newLogs),
+			});
+			act(() => publisherResult.current?.publishMessage(newEvent));
+			await waitFor(() => expect(hookResult.current).toEqual(newLogs));
+		}
 	});
 });
diff --git a/site/src/modules/resources/useAgentLogs.ts b/site/src/modules/resources/useAgentLogs.ts
@@ -32,6 +32,9 @@ export function createUseAgentLogs(options: CreateUseAgentLogsOptions) {
 			setLogs([]);
 			setPrevEnabled(false);
 		}
+		if (enabled && !prevEnabled) {
+			setPrevEnabled(true);
+		}
 
 		useEffect(() => {
 			if (!enabled) {

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,9 @@ export function createUseAgentLogs(options: CreateUseAgentLogsOptions) {`
`32`	`32`	`setLogs([]);`
`33`	`33`	`setPrevEnabled(false);`
`34`	`34`	`}`
	`35`	`+ if (enabled && !prevEnabled) {`
	`36`	`+ setPrevEnabled(true);`
	`37`	`+ }`
`35`	`38`
`36`	`39`	`useEffect(() => {`
`37`	`40`	`if (!enabled) {`