Skip to content

Commit 3e78053

Browse files
committed
Add some comments
1 parent 263b925 commit 3e78053

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

coderd/coderdtest/oidctest/idp.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1071,6 +1071,7 @@ func (f *FakeIDP) httpHandler(t testing.TB) http.Handler {
10711071

10721072
// Always invalidate the code after it is used.
10731073
f.codeToStateMap.Delete(code)
1074+
f.codeToChallengeMap.Delete(code)
10741075

10751076
idTokenClaims, ok := f.getClaims(f.stateToIDTokenClaims, stateStr)
10761077
if !ok {

codersdk/deployment.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,9 @@ type ExternalAuthConfig struct {
766766
// DisplayName is shown in the UI to identify the auth config.
767767
DisplayName string `json:"display_name" yaml:"display_name"`
768768
// DisplayIcon is a URL to an icon to display in the UI.
769-
DisplayIcon string `json:"display_icon" yaml:"display_icon"`
769+
DisplayIcon string `json:"display_icon" yaml:"display_icon"`
770+
// CodeChallengeMethodsSupported lists the PKCE code challenge methods
771+
// The only one supported by Coder is "S256"
770772
CodeChallengeMethodsSupported []string `json:"code_challenge_methods_supported" yaml:"code_challenge_methods_supported"`
771773
}
772774

0 commit comments

Comments
 (0)