fix(coderd): prevent idle state for non-active tasks

mafredri · mafredri · commit 3c84902adb23 · 2025-11-25T18:41:31.000Z
Previously, deriveTaskCurrentState would return "idle" state for all
tasks regardless of their status. This caused stopped or errored tasks
to incorrectly appear in the "Waiting for input" tab.

This fix specifically filters out only the "idle" state for non-active
tasks, while preserving other important states like "working", "complete",
or "failed" which remain meaningful even for stopped tasks.

The logic now checks: if the state is "idle" AND the task status is not
"active", skip setting that state. All other state/status combinations
pass through normally, ensuring we don't lose important state messages.

---

🤖 This change was written by Claude Code using Coder Tasks and reviewed by a human 🏂
diff --git a/coderd/aitasks.go b/coderd/aitasks.go
@@ -347,11 +347,20 @@ func deriveTaskCurrentState(
 	// still value in showing the latest app status.
 	if ws.LatestAppStatus != nil {
 		if ws.LatestBuild.Transition != codersdk.WorkspaceTransitionStart || ws.LatestAppStatus.CreatedAt.After(ws.LatestBuild.CreatedAt) {
-			currentState = &codersdk.TaskStateEntry{
-				Timestamp: ws.LatestAppStatus.CreatedAt,
-				State:     codersdk.TaskState(ws.LatestAppStatus.State),
-				Message:   ws.LatestAppStatus.Message,
-				URI:       ws.LatestAppStatus.URI,
+			appState := codersdk.TaskState(ws.LatestAppStatus.State)
+
+			// Don't show "idle" state for non-active tasks since the workspace
+			// is not actually running and waiting for input. Other states like
+			// "working", "complete", "failed" are still meaningful for stopped tasks.
+			shouldShowState := !(appState == codersdk.TaskStateIdle && dbTask.Status != database.TaskStatusActive)
+
+			if shouldShowState {
+				currentState = &codersdk.TaskStateEntry{
+					Timestamp: ws.LatestAppStatus.CreatedAt,
+					State:     appState,
+					Message:   ws.LatestAppStatus.Message,
+					URI:       ws.LatestAppStatus.URI,
+				}
 			}
 		}
 	}
